Skip to content

Commit c1d9ee2

Browse files
committed
fix(archiver): zero-seed l1_mismatch prune_type counter
l1_mismatch was added to recordPrune and emitted from the l1 synchronizer, but omitted from the prune_count default-values list, so the prune_count{prune_type="l1_mismatch"} series only appeared after the first such prune instead of from startup like the other causes. Add it to the zero-seed list and to the PRUNE_TYPE attribute doc comment.
1 parent 22c8ede commit c1d9ee2

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

yarn-project/archiver/src/modules/instrumentation.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export class ArchiverInstrumentation {
8585
this.pruneDuration = meter.createHistogram(Metrics.ARCHIVER_PRUNE_DURATION);
8686

8787
this.pruneCount = createUpDownCounterWithDefault(meter, Metrics.ARCHIVER_PRUNE_COUNT, {
88-
[Attributes.PRUNE_TYPE]: ['unproven', 'uncheckpointed', 'l1_conflict', 'orphan'],
88+
[Attributes.PRUNE_TYPE]: ['unproven', 'uncheckpointed', 'l1_conflict', 'orphan', 'l1_mismatch'],
8989
});
9090

9191
this.blockProposalTxTargetCount = createUpDownCounterWithDefault(

yarn-project/telemetry-client/src/attributes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export const OK = 'aztec.ok';
7373
export const STATUS = 'aztec.status';
7474
/** Generic error type attribute */
7575
export const ERROR_TYPE = 'aztec.error_type';
76-
/** The cause of an archiver prune (unproven / uncheckpointed / l1_conflict / orphan) */
76+
/** The cause of an archiver prune (unproven / uncheckpointed / l1_conflict / orphan / l1_mismatch) */
7777
export const PRUNE_TYPE = 'aztec.archiver.prune_type';
7878
/** The type of the transaction */
7979
export const L1_TX_TYPE = 'aztec.l1.tx_type';

0 commit comments

Comments
 (0)