Skip to content

Commit d06eb0f

Browse files
committed
chore(fast-inbox): fix l1 publisher revert assertion after inHash removal (A-1387)
The propose-failure test asserted the deleted Rollup__InvalidInHash selector (0xcd6f4233). With the legacy inHash L1 check gone, a checkpoint carrying messages that do not match the Inbox now reverts at validateInboxConsumption with Rollup__InvalidInboxRollingHash (0xed1f7bb5).
1 parent a87c067 commit d06eb0f

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

yarn-project/sequencer-client/src/publisher/l1_publisher.integration.test.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -964,9 +964,8 @@ describe('L1Publisher integration', () => {
964964
});
965965

966966
it(`shows propose custom errors if tx simulation fails`, async () => {
967-
// Set up different l1-to-l2 messages than the ones on the inbox, so this submission reverts because the
968-
// INBOX.consume does not match the header.inHash and we get a Rollup__BlobHash that is not caught by
969-
// validateHeader before.
967+
// Set up different l1-to-l2 messages than the ones on the inbox, so the checkpoint's inboxRollingHash does not
968+
// match the referenced Inbox bucket and the submission reverts at the streaming-consumption check.
970969
const l1ToL2Messages = new Array(MAX_L1_TO_L2_MSGS_PER_CHECKPOINT).fill(new Fr(1n));
971970
const { checkpoint } = await buildSingleCheckpoint({ l1ToL2Messages });
972971

@@ -981,12 +980,12 @@ describe('L1Publisher integration', () => {
981980
await progressToSlot(BigInt(checkpoint.header.slotNumber));
982981
const result = await publisher.sendRequests();
983982
expect(result).toBeUndefined();
984-
// 0xcd6f4233 == Rollup__InvalidInHash selector
983+
// 0xed1f7bb5 == Rollup__InvalidInboxRollingHash selector
985984
expect(loggerWarnSpy).toHaveBeenCalledWith(
986985
'Bundle entry dropped: action reverted in sim',
987986
expect.objectContaining({
988987
action: 'propose',
989-
returnData: expect.stringMatching(/^0xcd6f4233/),
988+
returnData: expect.stringMatching(/^0xed1f7bb5/),
990989
}),
991990
);
992991
});

0 commit comments

Comments
 (0)