prototype(pxe): skipSync flag on contract overrides

Alternative to inferring intent via on-chain class registration: declare it
explicitly per-override. Stub-builders (TestWallet, EmbeddedWallet, cli-wallet)
opt in with skipSync: true; real-class overrides (e.g. fastForwardContractUpdate)
leave it unset and sync runs as usual.

Not for merge — comparison branch only.

Author: dbanks12

yarn-project/cli-wallet/src/utils/wallet.ts

@@ -267,7 +267,7 @@ export class CLIWallet extends BaseWallet {
     } else {
       const { account, instance } = await this.getFakeAccountDataFor(from);
       overrides = {
-        contracts: { [from.toString()]: { instance } },
+        contracts: { [from.toString()]: { instance, skipSync: true } },
       };
       const executionOptions: DefaultAccountEntrypointOptions = {
         txNonce: Fr.random(),

yarn-project/end-to-end/src/test-wallet/test_wallet.ts

@@ -157,6 +157,7 @@ export class TestWallet extends BaseWallet {
 
       contracts[address.toString()] = {
         instance: { ...contractInstance, currentContractClassId: stubClassId },
+        skipSync: true,
       };
     }
 

yarn-project/pxe/src/pxe.ts

@@ -1013,9 +1013,18 @@ export class PXE {
         const contractFunctionSimulator = this.#getSimulatorForTx(overrides);
 
         if (hasOverriddenContracts) {
-          // Overridden contracts don't have a sync function, so calling sync on them would fail.
-          // We exclude them so the sync service skips them entirely.
-          this.contractSyncService.setExcludedFromSync(jobId, overriddenContracts);
+          // Skip sync only for overrides that explicitly opt out (typically mock/stub overrides whose
+          // artifact doesn't model the address's real notes). Real-class overrides (e.g. upgrade
+          // simulations via fastForwardContractUpdate) leave skipSync unset so sync runs as usual
+          // and pre-existing notes get discovered.
+          const skipSyncAddresses = new Set(
+            Object.entries(overrides!.contracts!)
+              .filter(([_addr, override]) => override.skipSync)
+              .map(([addr]) => addr),
+          );
+          if (skipSyncAddresses.size > 0) {
+            this.contractSyncService.setExcludedFromSync(jobId, skipSyncAddresses);
+          }
         }
 
         // Execution of private functions only; no proving, and no kernel logic.

yarn-project/stdlib/src/tx/simulated_tx.ts

@@ -29,8 +29,17 @@ import { Tx } from './tx.js';
  * overriding your own account contract so that valid signatures don't have to be provided while
  * simulating. The override's `currentContractClassId` resolves through PXE's locally registered
  * classes, so pre-register the target artifact via `pxe.registerContractClass(...)`.
+ *
+ * `skipSync` declares that PXE should not run contract sync (note discovery + nullifier sync) for
+ * this address while the override is in effect. Set this for mock/stub overrides whose artifact
+ * doesn't model the address's real notes (e.g. account stubs that mock auth without holding the
+ * real signing key storage). Leave unset (default false) for overrides that target full, on-chain
+ * classes where pre-existing notes still need to be discoverable (e.g. upgrade simulations).
  */
-export type ContractOverrides = Record<string /* AztecAddress as string */, { instance: ContractInstanceWithAddress }>;
+export type ContractOverrides = Record<
+  string /* AztecAddress as string */,
+  { instance: ContractInstanceWithAddress; skipSync?: boolean }
+>;
 
 /*
  * Optional values that can be overridden during simulation. `publicStorage` writes to the public-data
@@ -51,7 +60,12 @@ export class SimulationOverrides {
     return z
       .object({
         publicStorage: optional(z.array(PublicStorageOverrideSchema)),
-        contracts: optional(z.record(z.string(), z.object({ instance: ContractInstanceWithAddressSchema }))),
+        contracts: optional(
+          z.record(
+            z.string(),
+            z.object({ instance: ContractInstanceWithAddressSchema, skipSync: optional(z.boolean()) }),
+          ),
+        ),
       })
       .transform(args => new SimulationOverrides(args));
   }

yarn-project/wallets/src/embedded/embedded_wallet.ts

@@ -239,6 +239,7 @@ export class EmbeddedWallet extends BaseWallet {
 
       contracts[address.toString()] = {
         instance: { ...contractInstance, currentContractClassId: stubClassId },
+        skipSync: true,
       };
     }