fix: build native-packages Release/NDEBUG to match barretenberg (ODR)

The standalone wsdb/lmdblib/kvdb builds set no CMAKE_BUILD_TYPE, so they compiled
bb's headers (inline/template crypto + field code) without NDEBUG and without -O3,
while bb's prebuilt archive is Release (-O3 -DNDEBUG). bb headers are compiled into
both, so the NDEBUG/opt mismatch is an ODR violation that can silently diverge
inlined results (e.g. tree leaf hashing) -> the wsdb NullifierTree failing to find
a leaf pre-image by hash in e2e. Default these builds to Release to match bb.

Author: charlielye

native-packages/kvdb/cpp/CMakeLists.txt

@@ -14,6 +14,12 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
 set(CMAKE_POSITION_INDEPENDENT_CODE ON)
 set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)
 
+# Match barretenberg's prebuilt archive (Release -> -O3 -DNDEBUG): bb headers compiled
+# here must use the same NDEBUG/opt as bb to avoid ODR-divergent inlined code.
+if(NOT CMAKE_BUILD_TYPE)
+    set(CMAKE_BUILD_TYPE Release)
+endif()
+
 add_definitions(-DNAPI_VERSION=9)
 
 # ---------------------------------------------------------------------------

native-packages/lmdblib/cpp/CMakeLists.txt

@@ -19,6 +19,12 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
 set(CMAKE_POSITION_INDEPENDENT_CODE ON)
 set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)
 
+# Match barretenberg's prebuilt archive (Release -> -O3 -DNDEBUG): bb headers compiled
+# here must use the same NDEBUG/opt as bb to avoid ODR-divergent inlined code.
+if(NOT CMAKE_BUILD_TYPE)
+    set(CMAKE_BUILD_TYPE Release)
+endif()
+
 # ---------------------------------------------------------------------------
 # Third-party deps (own copies; commits must match barretenberg/cpp/cmake/*).
 # ---------------------------------------------------------------------------

native-packages/wsdb/cpp/CMakeLists.txt

@@ -20,6 +20,14 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
 set(CMAKE_POSITION_INDEPENDENT_CODE ON)
 set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin)
 
+# Match barretenberg's prebuilt archive build (Release -> -O3 -DNDEBUG). bb headers
+# (inline/template crypto + field code) are compiled into BOTH bb's Release archive
+# and this build; compiling them here without NDEBUG/-O3 is an ODR violation that can
+# silently diverge inlined results (e.g. tree leaf hashes). Default to Release.
+if(NOT CMAKE_BUILD_TYPE)
+    set(CMAKE_BUILD_TYPE Release)
+endif()
+
 # ---------------------------------------------------------------------------
 # Locate the prebuilt barretenberg tree.
 # ---------------------------------------------------------------------------