fix: wait for checkpoint during sandbox setup (#23834)

## Problem

CI on `merge-train/fairies` failed on the boxes `react chromium` test
([log](http://ci.aztec-labs.com/1780510430908759), [failing
test](http://ci.aztec-labs.com/243e7294cb8ba269)) with a timeout (code
124). The actual error was during `aztec start` / `createLocalNetwork`:

```
Error: Transaction 0x0826… was dropped. Reason: Tx dropped by P2P node
  at NodeEmbeddedWallet.sendTx
  at DeployAccountMethod.send
  at deployFundedSchnorrAccounts
  at createLocalNetwork
  at aztecStart
```

The local network never came up, so the browser test timed out.

## Root cause

PR #23819 ("embedded wallet defaults to proposed") fixed the embedded
wallet so its default wait status is *actually* `PROPOSED` — previously
the default was a no-op that fell through to `waitForTx`'s
`CHECKPOINTED` default.

`PROPOSED` returns as soon as a tx lands in a proposed L2 block. In the
serial sandbox setup that races against block pruning: a
proposed-but-not-checkpointed block can be pruned by end of build slot
(see #23606), and a tx in it is then neither in the archiver nor the
pool, so `getTxReceipt` returns `DroppedTxReceipt("Tx dropped by P2P
node")`. With the old broken default this path waited for `CHECKPOINTED`
and was reliable.

The real source of flakiness is the local network setup, not the boxes.

## Fix

Thread an explicit `{ waitForStatus: TxStatus.CHECKPOINTED }` wait
through the sandbox-setup sends:

- `createLocalNetwork`: `deployFundedSchnorrAccounts`,
`publishStandardAuthRegistry`, `setupBananaFPC`
- `setup-l2-contracts` CLI wait options

The intended product default of `PROPOSED` for normal wallet usage is
unchanged; only the CI/sandbox bring-up that needs durable inclusion
before the next serial tx is pinned to `CHECKPOINTED`. e2e fixtures use
`TestWallet` (BaseWallet's `CHECKPOINTED` default) and are unaffected.

Also reverts the per-box `CHECKPOINTED` waits that #23819 added to the
react/vite/vanilla boxes: they didn't fix the flakiness (the
local-network setup did), so the box sends go back to using the embedded
wallet `PROPOSED` default.

## Verification

TypeScript-only change in `yarn-project` plus box reverts; the box files
now match their pre-#23819 state exactly. A full `./bootstrap.sh ci`
could not be run in this container (clang 18 vs required 20, zig
missing, no remote build cache; the suite is multi-hour). Confirmed by
the merge-train CI re-run of the boxes tests.

Author: AztecBot

boxes/boxes/react/src/hooks/useContract.tsx

@@ -3,7 +3,6 @@ import { deployerEnv } from '../config';
 
 import { Contract } from '@aztec/aztec.js/contracts';
 import { Fr } from '@aztec/aztec.js/fields';
-import { TxStatus } from '@aztec/aztec.js/tx';
 import { toast } from 'react-toastify';
 
 export function useContract() {
@@ -21,8 +20,6 @@ export function useContract() {
 
     const deploymentPromise = BoxReactContract.deploy(wallet, Fr.random(), defaultAccountAddress).send({
       from: defaultAccountAddress,
-      // PROPOSED (the wallet default) is flaky in boxes CI, so wait for the checkpoint.
-      wait: { waitForStatus: TxStatus.CHECKPOINTED },
     });
 
     const { contract } = await toast.promise(deploymentPromise, {

boxes/boxes/react/src/hooks/useNumber.tsx

@@ -1,6 +1,5 @@
 import { useState } from 'react';
 import { Contract } from '@aztec/aztec.js/contracts';
-import { TxStatus } from '@aztec/aztec.js/tx';
 import { toast } from 'react-toastify';
 import { deployerEnv } from '../config';
 
@@ -29,10 +28,7 @@ export function useNumber({ contract }: { contract: Contract }) {
       const value = BigInt(el.value);
       const defaultAccountAddress = deployerEnv.getDefaultAccountAddress();
       await toast.promise(
-        // PROPOSED (the wallet default) is flaky in boxes CI, so wait for the checkpoint.
-        contract!.methods
-          .setNumber(value, defaultAccountAddress)
-          .send({ from: defaultAccountAddress, wait: { waitForStatus: TxStatus.CHECKPOINTED } }),
+        contract!.methods.setNumber(value, defaultAccountAddress).send({ from: defaultAccountAddress }),
         {
           pending: 'Setting number...',
           success: `Number set to: ${value}`,

boxes/boxes/vanilla/app/embedded-wallet.ts

@@ -6,7 +6,6 @@ import {
 import { SponsoredFeePaymentMethod } from '@aztec/aztec.js/fee';
 import { Fr } from '@aztec/aztec.js/fields';
 import { createLogger } from '@aztec/aztec.js/log';
-import { TxStatus } from '@aztec/aztec.js/tx';
 import { DeployAccountOptions } from '@aztec/aztec.js/wallet';
 import type { AztecNode } from '@aztec/aztec.js/node';
 import {
@@ -144,8 +143,7 @@ export class EmbeddedWallet extends EmbeddedWalletBase {
       },
       skipClassPublication: true,
       skipInstancePublication: true,
-      // PROPOSED (the wallet default) is flaky in boxes CI, so wait for the checkpoint.
-      wait: { timeout: 120, waitForStatus: TxStatus.CHECKPOINTED },
+      wait: { timeout: 120 },
     };
 
     const { receipt } = await deployMethod.send(deployOpts);

boxes/boxes/vanilla/app/main.ts

@@ -5,7 +5,6 @@ import {
   getContractInstanceFromInstantiationParams,
 } from '@aztec/aztec.js/contracts';
 import { Fr } from '@aztec/aztec.js/fields';
-import { TxStatus } from '@aztec/aztec.js/tx';
 import type { Wallet } from '@aztec/aztec.js/wallet';
 import { EmbeddedWallet } from './embedded-wallet';
 import { PrivateVotingContract } from '../artifacts/PrivateVoting';
@@ -163,11 +162,7 @@ voteButton.addEventListener('click', async (e) => {
     // Send tx
     await votingContract.methods
       .cast_vote({ id: electionId }, candidate)
-      // PROPOSED (the wallet default) is flaky in boxes CI, so wait for the checkpoint.
-      .send({
-        from: connectedAccount,
-        wait: { waitForStatus: TxStatus.CHECKPOINTED },
-      });
+      .send({ from: connectedAccount });
 
     // Update tally
     displayStatusMessage('Updating vote tally...');
@@ -203,10 +198,7 @@ async function updateVoteTally(wallet: Wallet, from: AztecAddress) {
     )
   );
 
-  const { result: batchResult } = await new BatchCall(
-    wallet,
-    payloads
-  ).simulate({ from });
+  const { result: batchResult } = await new BatchCall(wallet, payloads).simulate({ from });
 
   batchResult.forEach(({ result: value }, i) => {
     results[i + 1] = value;

boxes/boxes/vanilla/scripts/deploy.ts

@@ -8,7 +8,6 @@ import {
 import { SponsoredFeePaymentMethod } from '@aztec/aztec.js/fee';
 import { Fr } from '@aztec/aztec.js/fields';
 import { PublicKeys } from '@aztec/aztec.js/keys';
-import { TxStatus } from '@aztec/aztec.js/tx';
 import { createAztecNodeClient } from '@aztec/aztec.js/node';
 import type { DeployAccountOptions, Wallet } from '@aztec/aztec.js/wallet';
 import { type AztecNode } from '@aztec/aztec.js/node';
@@ -61,8 +60,7 @@ async function createAccount(wallet: EmbeddedWallet) {
     },
     skipClassPublication: true,
     skipInstancePublication: true,
-    // PROPOSED (the wallet default) is flaky in boxes CI, so wait for the checkpoint.
-    wait: { timeout: 120, waitForStatus: TxStatus.CHECKPOINTED },
+    wait: { timeout: 120 },
   };
   await deployMethod.send(deployOpts);
 
@@ -83,8 +81,7 @@ async function deployContract(wallet: Wallet, deployer: AztecAddress) {
         sponsoredPFCContract.address
       ),
     },
-    // PROPOSED (the wallet default) is flaky in CI, so wait for the checkpoint.
-    wait: { timeout: 120, waitForStatus: TxStatus.CHECKPOINTED },
+    wait: { timeout: 120 },
   });
 
   const electionId = new Fr(42);
@@ -96,8 +93,7 @@ async function deployContract(wallet: Wallet, deployer: AztecAddress) {
         sponsoredPFCContract.address
       ),
     },
-    // PROPOSED (the wallet default) is flaky in CI, so wait for the checkpoint.
-    wait: { timeout: 120, waitForStatus: TxStatus.CHECKPOINTED },
+    wait: { timeout: 120 },
   });
 
   return {

boxes/boxes/vite/src/hooks/useContract.tsx

@@ -3,7 +3,6 @@ import { deployerEnv } from '../config';
 
 import { Contract } from '@aztec/aztec.js/contracts';
 import { Fr } from '@aztec/aztec.js/fields';
-import { TxStatus } from '@aztec/aztec.js/tx';
 import { toast } from 'react-toastify';
 
 export function useContract() {
@@ -21,8 +20,6 @@ export function useContract() {
 
     const deploymentPromise = BoxReactContract.deploy(wallet, Fr.random(), defaultAccountAddress).send({
       from: defaultAccountAddress,
-      // PROPOSED (the wallet default) is flaky in boxes CI, so wait for the checkpoint.
-      wait: { waitForStatus: TxStatus.CHECKPOINTED },
     });
 
     const { contract } = await toast.promise(deploymentPromise, {

boxes/boxes/vite/src/hooks/useNumber.tsx

@@ -1,6 +1,5 @@
 import { useState } from 'react';
 import { Contract } from '@aztec/aztec.js/contracts';
-import { TxStatus } from '@aztec/aztec.js/tx';
 import { toast } from 'react-toastify';
 import { deployerEnv } from '../config';
 
@@ -29,10 +28,7 @@ export function useNumber({ contract }: { contract: Contract }) {
       const value = BigInt(el.value);
       const defaultAccountAddress = deployerEnv.getDefaultAccountAddress();
       await toast.promise(
-        // PROPOSED (the wallet default) is flaky in boxes CI, so wait for the checkpoint.
-        contract!.methods
-          .setNumber(value, defaultAccountAddress)
-          .send({ from: defaultAccountAddress, wait: { waitForStatus: TxStatus.CHECKPOINTED } }),
+        contract!.methods.setNumber(value, defaultAccountAddress).send({ from: defaultAccountAddress }),
         {
           pending: 'Setting number...',
           success: `Number set to: ${value}`,

yarn-project/aztec/src/local-network/auth_registry.ts

@@ -1,14 +1,19 @@
+import type { WaitOpts } from '@aztec/aztec.js/contracts';
 import { publishContractClass, publishInstance } from '@aztec/aztec.js/deployment';
 import type { Wallet } from '@aztec/aztec.js/wallet';
 import { AuthRegistryArtifact, getStandardAuthRegistry } from '@aztec/standard-contracts/auth-registry';
 import type { AztecAddress } from '@aztec/stdlib/aztec-address';
 
-export async function publishStandardAuthRegistry(wallet: Wallet, from: AztecAddress): Promise<void> {
+export async function publishStandardAuthRegistry(
+  wallet: Wallet,
+  from: AztecAddress,
+  waitOpts?: WaitOpts,
+): Promise<void> {
   const { instance, contractClass } = await getStandardAuthRegistry();
   if (!(await wallet.getContractClassMetadata(contractClass.id)).isContractClassPubliclyRegistered) {
-    await (await publishContractClass(wallet, AuthRegistryArtifact)).send({ from });
+    await (await publishContractClass(wallet, AuthRegistryArtifact)).send({ from, wait: waitOpts });
   }
   if (!(await wallet.getContractMetadata(instance.address)).isContractPublished) {
-    await publishInstance(wallet, instance).send({ from });
+    await publishInstance(wallet, instance).send({ from, wait: waitOpts });
   }
 }

yarn-project/aztec/src/local-network/banana_fpc.ts

@@ -1,4 +1,5 @@
 import { type InitialAccountData, getInitialTestAccountsData } from '@aztec/accounts/testing';
+import type { WaitOpts } from '@aztec/aztec.js/contracts';
 import type { Wallet } from '@aztec/aztec.js/wallet';
 import { Fr } from '@aztec/foundation/curves/bn254';
 import type { LogFn } from '@aztec/foundation/log';
@@ -45,16 +46,22 @@ export async function getBananaFPCAddress(initialAccounts: InitialAccountData[])
   return (await getBananaFPCInstance(initialAccounts)).address;
 }
 
-export async function setupBananaFPC(initialAccounts: InitialAccountData[], wallet: Wallet, log: LogFn) {
+export async function setupBananaFPC(
+  initialAccounts: InitialAccountData[],
+  wallet: Wallet,
+  log: LogFn,
+  waitOpts?: WaitOpts,
+) {
   const bananaCoinAddress = await getBananaCoinAddress(initialAccounts);
   const admin = getBananaAdmin(initialAccounts);
   const [{ contract: bananaCoin }, { contract: fpc }] = await Promise.all([
     TokenContract.deploy(wallet, admin, bananaCoinArgs.name, bananaCoinArgs.symbol, bananaCoinArgs.decimal, {
       salt: BANANA_COIN_SALT,
       universalDeploy: true,
-    }).send({ from: admin }),
+    }).send({ from: admin, wait: waitOpts }),
     FPCContract.deploy(wallet, bananaCoinAddress, admin, { salt: BANANA_FPC_SALT, universalDeploy: true }).send({
       from: admin,
+      wait: waitOpts,
     }),
   ]);
 

yarn-project/aztec/src/local-network/local-network.ts

@@ -22,6 +22,7 @@ import { protocolContractsHash } from '@aztec/protocol-contracts';
 import { SequencerState } from '@aztec/sequencer-client';
 import { AztecAddress } from '@aztec/stdlib/aztec-address';
 import type { ProvingJobBroker } from '@aztec/stdlib/interfaces/server';
+import { TxStatus } from '@aztec/stdlib/tx';
 import type { GenesisData } from '@aztec/stdlib/world-state';
 import {
   type TelemetryClient,
@@ -47,6 +48,12 @@ import { getSponsoredFPCAddress } from './sponsored_fpc.js';
 
 const logger = createLogger('local-network');
 
+// The embedded wallet defaults to waiting for PROPOSED, which returns as soon as a tx lands in a
+// proposed L2 block. That is flaky for the serial sandbox setup below: a proposed block can be
+// pruned before its checkpoint is published, dropping a tx we already moved on from ("Tx dropped by
+// P2P node"). Wait for the checkpoint so each setup tx is durably included before the next is sent.
+const setupWaitOpts = { waitForStatus: TxStatus.CHECKPOINTED };
+
 const localAnvil = foundry;
 
 /**
@@ -243,14 +250,14 @@ export async function createLocalNetwork(config: Partial<LocalNetworkConfig> = {
     });
 
     userLog('Setting up funded test accounts...');
-    const accountManagers = await deployFundedSchnorrAccounts(wallet, initialAccounts);
+    const accountManagers = await deployFundedSchnorrAccounts(wallet, initialAccounts, setupWaitOpts);
     const accLogs = await createAccountLogs(accountManagers, wallet);
     userLog(accLogs.join(''));
 
     userLog('Publishing standard AuthRegistry contract...');
-    await publishStandardAuthRegistry(wallet, initialAccounts[0].address);
+    await publishStandardAuthRegistry(wallet, initialAccounts[0].address, setupWaitOpts);
 
-    await setupBananaFPC(initialAccounts, wallet, userLog);
+    await setupBananaFPC(initialAccounts, wallet, userLog, setupWaitOpts);
 
     userLog(`SponsoredFPC: ${await getSponsoredFPCAddress()}`);