chore(fast-inbox): drop inert isFirstBlock parameter from blob-data fixtures (A-1384)

Author: spalladino

yarn-project/archiver/src/l1/data_retrieval.test.ts

@@ -16,9 +16,9 @@ describe('data_retrieval', () => {
       const body3 = await Body.random({ txsPerBlock: 2 });
 
       // Convert to BlockBlobData
-      const block1BlobData = makeBlockBlobDataFromBody(body1, BlockNumber(1), true, 1000);
-      const block2BlobData = makeBlockBlobDataFromBody(body2, BlockNumber(2), false, 2000);
-      const block3BlobData = makeBlockBlobDataFromBody(body3, BlockNumber(3), false, 3000);
+      const block1BlobData = makeBlockBlobDataFromBody(body1, BlockNumber(1), 1000);
+      const block2BlobData = makeBlockBlobDataFromBody(body2, BlockNumber(2), 2000);
+      const block3BlobData = makeBlockBlobDataFromBody(body3, BlockNumber(3), 3000);
 
       // Calculate total blob fields for checkpoint end marker
       const numBlobFields = 100; // Approximate, doesn't need to be exact for this test
@@ -96,7 +96,7 @@ describe('data_retrieval', () => {
 
     it('handles single-block checkpoint', async () => {
       const body1 = await Body.random({ txsPerBlock: 3 });
-      const block1BlobData = makeBlockBlobDataFromBody(body1, BlockNumber(1), true, 5000);
+      const block1BlobData = makeBlockBlobDataFromBody(body1, BlockNumber(1), 5000);
 
       const checkpointBlobData: CheckpointBlobData = {
         blocks: [block1BlobData],
@@ -134,15 +134,9 @@ describe('data_retrieval', () => {
  * Helper to create a BlockBlobData from a Body. This ensures the blob data is compatible
  * with Body.fromTxBlobData.
  */
-function makeBlockBlobDataFromBody(
-  body: Body,
-  blockNumber: BlockNumber,
-  isFirstBlock: boolean,
-  seed: number,
-): BlockBlobData {
+function makeBlockBlobDataFromBody(body: Body, blockNumber: BlockNumber, seed: number): BlockBlobData {
   const blockEndBlobData = makeBlockEndBlobData({
     seed,
-    isFirstBlock,
     blockEndMarker: {
       numTxs: body.txEffects.length,
       blockNumber,

yarn-project/blob-lib/src/encoding/block_blob_data.test.ts

@@ -2,18 +2,8 @@ import { decodeBlockBlobData, encodeBlockBlobData } from './block_blob_data.js';
 import { makeBlockBlobData } from './fixtures.js';
 
 describe('block blob data', () => {
-  it('encode and decode first block', () => {
-    const blockBlobData = makeBlockBlobData({ isFirstBlock: true, numTxs: 3 });
-    expect(blockBlobData.txs.length).toBe(3);
-    expect(blockBlobData.l1ToL2MessageRoot).toBeDefined();
-
-    const encoded = encodeBlockBlobData(blockBlobData);
-    const decoded = decodeBlockBlobData(encoded);
-    expect(decoded).toEqual(blockBlobData);
-  });
-
-  it('encode and decode non-first block (still carries the l1-to-l2 root)', () => {
-    const blockBlobData = makeBlockBlobData({ isFirstBlock: false, numTxs: 3 });
+  it('encodes and decodes a block carrying the l1-to-l2 message root', () => {
+    const blockBlobData = makeBlockBlobData({ numTxs: 3 });
     expect(blockBlobData.txs.length).toBe(3);
     // Every block carries the l1-to-l2 message tree root post-flip (AZIP-22 Fast Inbox).
     expect(blockBlobData.l1ToL2MessageRoot).toBeDefined();

yarn-project/blob-lib/src/encoding/fixtures.ts

@@ -131,14 +131,9 @@ export function makeBlockEndStateField({
 }
 
 export function makeBlockEndBlobData({
-  // Accepted for call-site compatibility, but no longer read: post-flip every block carries the
-  // l1-to-l2 message tree root regardless of position, so the blob format no longer branches on it.
-  isFirstBlock: _isFirstBlock = true,
   seed = 1,
   ...overrides
-}: { seed?: number; isFirstBlock?: boolean } & Partial<
-  Omit<BlockEndBlobData, 'blockEndMarker' | 'blockEndStateField'>
-> & {
+}: { seed?: number } & Partial<Omit<BlockEndBlobData, 'blockEndMarker' | 'blockEndStateField'>> & {
     blockEndMarker?: Partial<BlockEndMarker>;
     blockEndStateField?: Partial<BlockEndStateField>;
   } = {}): BlockEndBlobData {
@@ -162,11 +157,10 @@ export function makeBlockEndBlobData({
 
 export function makeBlockBlobData({
   numTxs = 1,
-  isFirstBlock = true,
   isFullTx = false,
   seed = 1,
   ...overrides
-}: { numTxs?: number; isFirstBlock?: boolean; isFullTx?: boolean; seed?: number } & Partial<
+}: { numTxs?: number; isFullTx?: boolean; seed?: number } & Partial<
   Parameters<typeof makeBlockEndBlobData>[0]
 > = {}): BlockBlobData {
   return {
@@ -176,7 +170,6 @@ export function makeBlockBlobData({
       blockEndMarker: {
         numTxs,
       },
-      isFirstBlock,
       ...overrides,
     }),
   };
@@ -196,11 +189,7 @@ export function makeCheckpointBlobData({
 } & Partial<CheckpointBlobData> = {}): CheckpointBlobData {
   const blocks =
     overrides.blocks ??
-    makeTuple(
-      numBlocks,
-      i => makeBlockBlobData({ numTxs: numTxsPerBlock, isFirstBlock: i === seed, isFullTx, seed: seed + i * 0x1000 }),
-      seed,
-    );
+    makeTuple(numBlocks, i => makeBlockBlobData({ numTxs: numTxsPerBlock, isFullTx, seed: seed + i * 0x1000 }), seed);
 
   const numBlobFields =
     overrides.checkpointEndMarker?.numBlobFields ??