Skip to content

Commit e62bd70

Browse files
authored
chore(sequencer): add context to proposer-rollup-check-failed logs (#23071)
Logging-only change
1 parent 7dee5cd commit e62bd70

1 file changed

Lines changed: 16 additions & 3 deletions

File tree

yarn-project/sequencer-client/src/sequencer/sequencer.ts

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -408,10 +408,22 @@ export class Sequencer extends (EventEmitter as new () => TypedEventEmitter<Sequ
408408
simulationOverridesPlan,
409409
);
410410

411+
const proposeContext = {
412+
hasProposedCheckpoint: syncedTo.hasProposedCheckpoint,
413+
proposedCheckpointNumber: syncedTo.proposedCheckpointData?.checkpointNumber,
414+
checkpointedCheckpointNumber: syncedTo.checkpointedCheckpointNumber,
415+
isInvalidating: !!invalidateCheckpoint,
416+
invalidatingCheckpointNumber: invalidateCheckpoint?.checkpointNumber,
417+
archiveForCheck: archiveForCheck.toString(),
418+
overridePendingCheckpointNumber: simulationOverridesPlan?.pendingCheckpointNumber,
419+
overrideArchive: simulationOverridesPlan?.pendingCheckpointState?.archive,
420+
overrideFeeHeader: simulationOverridesPlan?.pendingCheckpointState?.feeHeader,
421+
};
422+
411423
if (canProposeCheck === undefined) {
412424
this.log.warn(
413425
`Cannot propose checkpoint ${checkpointNumber} at slot ${slot} due to failed rollup contract check`,
414-
logCtx,
426+
{ ...logCtx, ...proposeContext },
415427
);
416428
this.emit('proposer-rollup-check-failed', { reason: 'Rollup contract check failed', slot });
417429
this.metrics.recordCheckpointPrecheckFailed('rollup_contract_check_failed');
@@ -421,7 +433,7 @@ export class Sequencer extends (EventEmitter as new () => TypedEventEmitter<Sequ
421433
if (canProposeCheck.slot !== targetSlot) {
422434
this.log.warn(
423435
`Cannot propose block due to slot mismatch with rollup contract (this can be caused by a clock out of sync). Expected slot ${targetSlot} but got ${canProposeCheck.slot}.`,
424-
{ ...logCtx, rollup: canProposeCheck, expectedSlot: targetSlot },
436+
{ ...logCtx, ...proposeContext, rollup: canProposeCheck, expectedSlot: targetSlot },
425437
);
426438
this.emit('proposer-rollup-check-failed', { reason: 'Slot mismatch', slot });
427439
this.metrics.recordCheckpointPrecheckFailed('slot_mismatch');
@@ -431,7 +443,7 @@ export class Sequencer extends (EventEmitter as new () => TypedEventEmitter<Sequ
431443
if (canProposeCheck.checkpointNumber !== checkpointNumber) {
432444
this.log.warn(
433445
`Cannot propose due to block mismatch with rollup contract (this can be caused by a pending archiver sync). Expected checkpoint ${checkpointNumber} but got ${canProposeCheck.checkpointNumber}.`,
434-
{ ...logCtx, rollup: canProposeCheck, expectedSlot: slot },
446+
{ ...logCtx, ...proposeContext, rollup: canProposeCheck, expectedSlot: slot },
435447
);
436448
this.emit('proposer-rollup-check-failed', { reason: 'Block mismatch', slot });
437449
this.metrics.recordCheckpointPrecheckFailed('block_number_mismatch');
@@ -445,6 +457,7 @@ export class Sequencer extends (EventEmitter as new () => TypedEventEmitter<Sequ
445457
`Preparing checkpoint proposal ${checkpointNumber} for target slot ${targetSlot} during wall-clock slot ${slot}`,
446458
{
447459
...logCtx,
460+
...proposeContext,
448461
proposer,
449462
pipeliningEnabled: this.epochCache.isProposerPipeliningEnabled(),
450463
},

0 commit comments

Comments
 (0)