feat(avm)!: WIP remove is_infinite flags from ECADD opcode (outside AVM only) (#23031)

This branch includes the changes to remove the `is_infinite` flags from
the ECADD opcode fn signature which reside outside `vm2`. This includes
the transpiler, ts simulator, and anything required in ACIR.

Note that ACIR and noir's black box still use [the
flags](https://github.com/AztecProtocol/aztec-packages/blob/b30fe8f401d7af45148071924b22b3f377750eaf/barretenberg/cpp/src/barretenberg/dsl/acir_format/ec_operations.hpp#L34)
and represent points by a[ triple of
elements.](https://github.com/noir-lang/noir/blob/bc4a37e2994ebc7d44ae98be81e18606b2231c61/acvm-repo/bn254_blackbox_solver/src/embedded_curve_ops.rs#L98)
Since this touches both private and public execution, I think it's out
of scope of this task to update these.

Will partially close [Foundation AVM Issue
19](https://linear.app/aztec-foundation/issue/AVM-19/) (the previous PR
with AVM changes will close the initial portion)

---

Stack:
- #22745
- #22564
- #22921
- #22795
- #22945
- `mw/avm-rem-inf-opcode-ecadd-ext` <-- here

Author: MirandaWood

avm-transpiler/src/procedures/msm.rs

@@ -1,11 +1,11 @@
 pub(crate) const MSM_ASSEMBLY: &str = "
                 ; We are passed three pointers and one usize.
-                ; d0 points to the points. Points are represented by (x: Field, y: Field). The point at infinity is (0, 0).
+                ; d0 points to the points. Points are represented by (x: Field, y: Field).
                 ; d1 points to the scalars. Scalars are represented by (lo: Field, hi: Field) both range checked to 128 bits.
                 ; d2 contains the number of points.
                 ; d3 points to the result. The result is a point.
                 ADD d3, /*the reserved register 'one_usize'*/ $2, d4; Compute the pointer to the result y.
-                ; Initialize the msm result: point at infinity (0, 0)
+                ; Initialize the msm result: point at infinity
                 SET i3, 0 ff
                 SET i4, 0 ff
                 ; Loop globals

avm-transpiler/src/transpile.rs

@@ -1285,7 +1285,7 @@ fn handle_black_box_function(
             result,
         } => avm_instrs.push(AvmInstruction {
             opcode: AvmOpcode::ECADD,
-            // The result (SIXTH operand) is indirect (addressing mode).
+            // The result (FOURTH operand) is indirect (addressing mode).
             addressing_mode: Some(
                 AddressingModeBuilder::default()
                     .direct_operand(p1_x_offset)

barretenberg/cpp/src/barretenberg/aztec/aztec_constants.hpp

@@ -233,7 +233,7 @@
 #define AVM_POSEIDON2_BASE_L2_GAS 360
 #define AVM_SHA256COMPRESSION_BASE_L2_GAS 12288
 #define AVM_KECCAKF1600_BASE_L2_GAS 58176
-#define AVM_ECADD_BASE_L2_GAS 270
+#define AVM_ECADD_BASE_L2_GAS 180
 #define AVM_TORADIXBE_BASE_L2_GAS 24
 #define AVM_CALLDATACOPY_DYN_L2_GAS 3
 #define AVM_RETURNDATACOPY_DYN_L2_GAS 3

barretenberg/cpp/src/barretenberg/vm2/constraining/avm_fixed_vk.hpp

@@ -17,7 +17,7 @@ class AvmHardCodedVKAndHash {
     using FF = bb::curve::BN254::ScalarField;
 
     // Precomputed VK hash (hash of all commitments below).
-    static FF vk_hash() { return FF(uint256_t("0x0f0714f53e7fcf7ffb15cfb22b7a1614c65f01742706b0ca20eb80454eaf1e48")); }
+    static FF vk_hash() { return FF(uint256_t("0x00b6d67db723a570d7686fbcb5f3c4c39945378222f37e86fa9f511af4c036b5")); }
 
     static constexpr std::array<Commitment, NUM_PRECOMPUTED_ENTITIES> get_all()
     {
@@ -71,9 +71,9 @@ class AvmHardCodedVKAndHash {
                 uint256_t(
                     "0x090dda25e7d64ab5cabe09fd80fbb731af2a98de7a608157dc10394b4fc022a4")), // precomputed_exec_opcode_dynamic_l2_gas
             Commitment(
-                uint256_t("0x26086b5fb31a24f236f0441d5b922b94ca141e861b9cc640184681c518cd68d3"),
+                uint256_t("0x1fbccee2ff656d845414c1a520adde56aa3625e29b6fff377044986493023e6d"),
                 uint256_t(
-                    "0x0bab134bb4e25ff33584c1094847e762ce6573054bae27715d0e4eb2b7278d80")), // precomputed_exec_opcode_opcode_gas
+                    "0x05c88802d3174f1c7b3c9aa1abf4754ebdaf6409d1aaf1dfa3f551da1c10fa93")), // precomputed_exec_opcode_opcode_gas
             Commitment(
                 uint256_t("0x296def9415d1c96b4d8ab91df5f59ad8522a726f98461b1ab5c4d4c5b22471a4"),
                 uint256_t(

noir-projects/noir-protocol-circuits/crates/types/src/constants.nr

@@ -1240,7 +1240,7 @@ pub global AVM_DEBUGLOG_BASE_L2_GAS: u32 = 9;
 pub global AVM_POSEIDON2_BASE_L2_GAS: u32 = 24 * 15; // SLOW_SIM_MUL = 15
 pub global AVM_SHA256COMPRESSION_BASE_L2_GAS: u32 = 12288;
 pub global AVM_KECCAKF1600_BASE_L2_GAS: u32 = 58176;
-pub global AVM_ECADD_BASE_L2_GAS: u32 = 27 * 10; // SLOW_SIM_MUL = 10
+pub global AVM_ECADD_BASE_L2_GAS: u32 = 18 * 10; // SLOW_SIM_MUL = 10
 pub global AVM_TORADIXBE_BASE_L2_GAS: u32 = 24;
 
 // Dynamic L2 GAS

yarn-project/constants/src/constants.gen.ts

@@ -460,7 +460,7 @@ export const AVM_DEBUGLOG_BASE_L2_GAS = 9;
 export const AVM_POSEIDON2_BASE_L2_GAS = 360;
 export const AVM_SHA256COMPRESSION_BASE_L2_GAS = 12288;
 export const AVM_KECCAKF1600_BASE_L2_GAS = 58176;
-export const AVM_ECADD_BASE_L2_GAS = 270;
+export const AVM_ECADD_BASE_L2_GAS = 180;
 export const AVM_TORADIXBE_BASE_L2_GAS = 24;
 export const AVM_CALLDATACOPY_DYN_L2_GAS = 3;
 export const AVM_RETURNDATACOPY_DYN_L2_GAS = 3;

yarn-project/simulator/docs/avm/avm-isa-quick-reference.md

@@ -250,9 +250,9 @@ Click on an opcode name to view its detailed documentation.
 * **[🔗ECADD](opcodes/ecadd.md)**: Grumpkin elliptic curve addition
     * Opcode `0x42`
     ```javascript
-    M[dstOffset:dstOffset+3] = grumpkinAdd(
-        /*point1=*/{x: M[p1XOffset], y: M[p1YOffset], isInfinite: M[p1IsInfiniteOffset]},
-        /*point2=*/{x: M[p2XOffset], y: M[p2YOffset], isInfinite: M[p2IsInfiniteOffset]}
+    M[dstOffset:dstOffset+1] = grumpkinAdd(
+        /*point1=*/{x: M[p1XOffset], y: M[p1YOffset]},
+        /*point2=*/{x: M[p2XOffset], y: M[p2YOffset]}
     )
     ```
 * **[🔗TORADIXBE](opcodes/toradixbe.md)**: Convert to radix (big-endian)