Commit ea54ad4
authored
fix: port bb socket startup retry to next (#24960)
## Summary
Ports #24802 to
`next`.
This keeps the same behavior change from the merged v5 PR:
- bb.js native socket startup now waits while the bb process remains
alive, with a 60s wedged-process backstop instead of the old shared 5s
socket/connect deadline.
- bb startup failures are wrapped as retryable `ProvingError`s in
bb-prover.
- retryability is preserved when bb-prover re-wraps proof generation and
verification failures.
## Conflict resolution
The automatic cherry-pick conflicted because `barretenberg/ts/src/...`
on the source branch has moved to `barretenberg/ts/bb.js/src/...` on
`next`.
Resolved by adapting the socket backend changes into the `bb.js` path
and preserving `next`'s `createAsyncBackend` API shape, which returns
`IMsgpackBackendAsync` rather than constructing a `Barretenberg` wrapper
there. Added a small follow-up commit to satisfy the `next` lint rule
for `destroy()`.
Refs #24802
## Verification
- `git diff --check origin/next...HEAD`
- `yarn formatting:fix` in `barretenberg/ts/bb.js`
- `yarn test bb_backends/node/native_socket.test.ts --runInBand` in
`barretenberg/ts/bb.js`
Blocked locally:
- `./bootstrap.sh build` in `barretenberg/ts/bb.js` passed formatting,
then stopped at codegen because this checkout lacks
`barretenberg/cpp/build/bin/bb`.
- `JEST_MAX_WORKERS=1 yarn workspace @aztec/bb-prover test
src/bb/bb_js_backend.test.ts` could not complete in this cold checkout
without built workspace exports for `@aztec/bb.js`/`@aztec/foundation`.
---
*Created by
[claudebox](https://claudebox.work/v2/sessions/f03a66a010266d34/jobs/1)
· group: `slackbot` · [Slack
thread](https://aztecprotocol.slack.com/archives/C0AGN2WT3CP/p1784890226762699?thread_ts=1784890226.762699&cid=C0AGN2WT3CP)*6 files changed
Lines changed: 227 additions & 201 deletions
File tree
- barretenberg/ts/bb.js/src/bb_backends/node
- yarn-project/bb-prover/src
- bb
- prover/server
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
Lines changed: 82 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
0 commit comments