Commit eba6e49
committed
fix(docs): address review comments on v4.1.3 versioned docs
Fixed valid issues identified by code review:
- Contract import: use '@aztec/aztec.js/contracts' subpath, not root
- TestWallet: replaced internal e2e helper with public EmbeddedWallet API
- Transfer test: use transfer_in_public for public balance assertions
- simulate() destructuring: wrap with { result } in how_to_read_data
- Deploy guide: use consistent TokenContract import matching the example
Dismissed invalid claims (verified against v4.1.3 SDK source):
- AztecAddress.ZERO is correct for self-deploy (not NO_FROM)
- isContractInitialized exists on ContractMetadata (not initializationStatus)
- GasSettings.default() exists at v4.1.3 (takes maxFeesPerGas param)1 parent 9ac97e9 commit eba6e49
File tree
4 files changed
+17
-15
lines changed- docs/developer_versioned_docs/version-v4.1.3/docs/aztec-js
4 files changed
+17
-15
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
Lines changed: 14 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
| 22 | + | |
22 | 23 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
| 24 | + | |
| 25 | + | |
28 | 26 | | |
29 | | - | |
| 27 | + | |
| 28 | + | |
30 | 29 | | |
31 | | - | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
32 | 35 | | |
33 | | - | |
34 | 36 | | |
35 | 37 | | |
36 | 38 | | |
| |||
165 | 167 | | |
166 | 168 | | |
167 | 169 | | |
168 | | - | |
169 | | - | |
| 170 | + | |
| 171 | + | |
170 | 172 | | |
171 | 173 | | |
172 | 174 | | |
| |||
188 | 190 | | |
189 | 191 | | |
190 | 192 | | |
191 | | - | |
| 193 | + | |
192 | 194 | | |
193 | 195 | | |
194 | 196 | | |
| |||
0 commit comments