feat(ci): Snapshots for aztec-nr contract compilation failures and nargo expand (#23061)

Resolves
[F-607](https://linear.app/aztec-labs/issue/F-607/adopt-cargo-insta-for-noir-contract-snapshot-testing)

Don't be scared by the diff size, the majority of the diff is new
snapshots.

- Deleted `noir-projects/noir-contracts-comp-failures/` crate. We now
have `noir-projects/contract-snapshots/`
- `nargo expand` tests cover Token, AMM, StorageProofTest, AvmTest,
AvmGadgetsTest to match the CI benchmarks
- `compile_failure` snapshots are now full stderr (not just `error: `
headlines)

Asserting the full stderr and `expand` output provide us a strong test
invariant on the current compiler behavior. Some of the expanded
snapshots are quite large, and that is why I ultimately chose to only
have snapshots for the benchmark contracts. For compilation failures, I
felt it would be better to have the full snapshot in all cases. We then
assert against the actual compiler behavior rather than some stripped
version of the stderr.

A great example of how these snapshots are useful can be seen in the
child PR #23062.

Author: vezenovm

Makefile

@@ -301,7 +301,6 @@ aztec-nr: noir bb-cpp-native
 noir-projects-txe-tests:
 	$(call test,$@,noir-projects/aztec-nr)
 	$(call test,$@,noir-projects/noir-contracts)
-	$(call test,$@,noir-projects/noir-contracts-comp-failures)
 
 # Noir Projects - Aggregate target (builds all sub-projects)
 noir-projects: noir-protocol-circuits mock-protocol-circuits noir-contracts aztec-nr

cspell.json

@@ -71,6 +71,7 @@
     "cimg",
     "ciphertext",
     "ciphertexts",
+    "clippy",
     "clonedeep",
     "clonedeepwith",
     "cmd",
@@ -171,6 +172,7 @@
     "includable",
     "incrementation",
     "indexeddb",
+    "INSTA",
     "interruptible",
     "IPFS",
     "isequal",
@@ -367,8 +369,8 @@
     "unfinalized",
     "uniquified",
     "uniquify",
-    "unlinkability",
     "unkonstrained",
+    "unlinkability",
     "unnullify",
     "unpadded",
     "unprefixed",

noir-projects/bootstrap.sh

@@ -26,7 +26,7 @@ function build {
 }
 
 function test_cmds {
-  parallel -k ./{}/bootstrap.sh test_cmds ::: noir-protocol-circuits noir-contracts aztec-nr noir-contracts-comp-failures
+  parallel -k ./{}/bootstrap.sh test_cmds ::: noir-protocol-circuits noir-contracts aztec-nr contract-snapshots
 }
 
 function test {

noir-projects/contract-snapshots/.gitignore

@@ -0,0 +1 @@
+/**/target/