docs(fast-inbox): state circuits and stdlib inbox comments on their own terms (A-1432)

Author: spalladino

noir-projects/noir-protocol-circuits/crates/rollup-lib/src/abis/mod.nr

@@ -1,6 +1,6 @@
 // TODO: Move to types/src/abis/rollup/
-// `l1_to_l2_message_sponge` is declared first because the serde `#[derive(...)]` macro requires a field type's module
-// to be declared before any struct that embeds it (see the ordering note in `types/src/lib.nr`).
+// `l1_to_l2_message_sponge` is declared first because the `#[derive(Serialize, Deserialize)]` macros require a field
+// type's module to be declared before any struct that embeds it (see the ordering note in `types/src/lib.nr`).
 mod l1_to_l2_message_sponge;
 mod l1_to_l2_message_bundle;
 mod public_chonk_verifier_public_inputs;

noir-projects/noir-protocol-circuits/crates/rollup-lib/src/abis/root_rollup_public_inputs.nr

@@ -18,8 +18,7 @@ pub struct RootRollupPublicInputs {
     // The out hash of the first checkpoint in the epoch is inserted at index 0, the second at index 1, and so on.
     pub out_hash: Field,
     // Inbox rolling-hash chain segment consumed across the epoch: the chain value before the first checkpoint's
-    // messages and after the last checkpoint's. Continuity within the range is enforced by the checkpoint merges;
-    // L1 passes both through to proof verification without validating them until the Fast Inbox flip.
+    // messages and after the last checkpoint's. Continuity within the range is enforced by the checkpoint merges.
     pub previous_inbox_rolling_hash: Field,
     pub end_inbox_rolling_hash: Field,
     // Checkpoint header hashes for each checkpoint in this epoch.

noir-projects/noir-protocol-circuits/crates/rollup-lib/src/block_merge/utils/validate_consecutive_block_rollups.nr

@@ -42,8 +42,6 @@ fn assert_prev_block_rollups_follow_on_from_each_other(
         "Mismatched timestamps: expected right.timestamp to match left.timestamp",
     );
 
-    // TODO: Consider extracting into its own function:
-
     // `is_first_block` originates from the first block root only, and is propagated through all merge steps via the
     // left rollup only (see merge_block_rollups.nr). We prevent the right rollup from carrying it, so it's impossible
     // for any block but the first to propagate `is_first_block == true` up to the checkpoint root.

noir-projects/noir-protocol-circuits/crates/rollup-lib/src/checkpoint_merge/utils/validate_consecutive_checkpoint_rollups.nr

@@ -31,7 +31,7 @@ fn assert_rollups_follow_on_from_each_other(
 
     // The inbox rolling-hash chain must be continuous across consecutive checkpoints: the right checkpoint's chain must
     // start where the left checkpoint's chain ended. An end-only anchor would let a prover restart the chain from an
-    // earlier bucket and re-insert already-consumed messages, so continuity is enforced here (see AZIP-22).
+    // earlier bucket and re-insert already-consumed messages, so continuity is enforced here.
     assert_eq(
         left.end_inbox_rolling_hash,
         right.start_inbox_rolling_hash,

noir-projects/noir-protocol-circuits/crates/rollup-lib/src/checkpoint_root/checkpoint_root_rollup.nr

@@ -29,8 +29,8 @@ global ALLOWED_PREVIOUS_VK_INDICES: [u32; 7] = [
 
 pub struct CheckpointRootRollupPrivateInputs {
     pub(crate) previous_rollups: [RollupHonkProofData<BlockRollupPublicInputs>; 2],
-    // Inbox parity proof over the checkpoint's L1-to-L2 messages. One variable-size proof per checkpoint (AZIP-22 Fast
-    // Inbox): the checkpoint root is the only circuit that sees the whole checkpoint's message commitments.
+    // Inbox parity proof over the checkpoint's L1-to-L2 messages. One variable-size proof per checkpoint: the
+    // checkpoint root is the only circuit that sees the whole checkpoint's message commitments.
     pub(crate) inbox_parity: UltraHonkProofData<ParityPublicInputs>,
     pub(crate) hints: CheckpointRootRollupHints,
 }

noir-projects/noir-protocol-circuits/crates/rollup-lib/src/checkpoint_root/checkpoint_root_single_block_rollup.nr

@@ -32,8 +32,8 @@ global ALLOWED_PREVIOUS_VK_INDICES: [u32; 4] = [
 
 pub struct CheckpointRootSingleBlockRollupPrivateInputs {
     pub(crate) previous_rollup: RollupHonkProofData<BlockRollupPublicInputs>,
-    // Inbox parity proof over the checkpoint's L1-to-L2 messages. One variable-size proof per checkpoint (AZIP-22 Fast
-    // Inbox): the checkpoint root is the only circuit that sees the whole checkpoint's message commitments.
+    // Inbox parity proof over the checkpoint's L1-to-L2 messages. One variable-size proof per checkpoint: the
+    // checkpoint root is the only circuit that sees the whole checkpoint's message commitments.
     pub(crate) inbox_parity: UltraHonkProofData<ParityPublicInputs>,
     pub(crate) hints: CheckpointRootRollupHints,
 }

noir-projects/noir-protocol-circuits/crates/rollup-lib/src/checkpoint_root/components/checkpoint_rollup_public_inputs_composer.nr

@@ -117,9 +117,8 @@ impl<let NumBlobs: u32> CheckpointRollupPublicInputsComposer<NumBlobs> {
             new_archive: merged_rollup.new_archive,
             previous_out_hash: self.previous_out_hash,
             new_out_hash,
-            // Sourced from the inbox parity proof (parity moved to the checkpoint root in AZIP-22 Fast Inbox), which
-            // commits to the same message list behind the L1-checked `in_hash`. Checkpoint merges assert continuity
-            // across checkpoints (`right.start == left.end`).
+            // Sourced from the inbox parity proof, which commits to the same message list behind the L1-checked
+            // `in_hash`. Checkpoint merges assert continuity across checkpoints (`right.start == left.end`).
             start_inbox_rolling_hash: self.parity.start_rolling_hash,
             end_inbox_rolling_hash: self.parity.end_rolling_hash,
             checkpoint_header_hashes,

noir-projects/noir-protocol-circuits/crates/rollup-lib/src/parity/inbox_parity.nr

@@ -28,7 +28,7 @@ pub struct InboxParityPrivateInputs<let S: u32> {
 
 /// The Inbox Parity circuit recomputes, for one checkpoint, the Inbox rolling-hash chain over the checkpoint's real
 /// L1-to-L2 messages and absorbs the same real messages into the message-bundle sponge. It replaces the parity base +
-/// parity root family with a single variable-size proof per checkpoint (AZIP-22 Fast Inbox / A-1376 topology).
+/// parity root family with a single variable-size proof per checkpoint.
 ///
 /// This circuit:
 /// - Chains the `num_msgs` real messages into the rolling hash (two sha256 compressions per leaf)

yarn-project/ethereum/src/contracts/rollup.ts

@@ -68,9 +68,9 @@ export type EpochProofPublicInputArgs = {
   previousArchive: `0x${string}`;
   endArchive: `0x${string}`;
   outHash: `0x${string}`;
-  /** Inbox rolling hash before the epoch's first checkpoint; unvalidated by L1 until the Fast Inbox flip. */
+  /** Inbox rolling hash before the epoch's first checkpoint's messages. */
   previousInboxRollingHash: `0x${string}`;
-  /** Inbox rolling hash after the epoch's last checkpoint; unvalidated by L1 until the Fast Inbox flip. */
+  /** Inbox rolling hash after the epoch's last checkpoint's messages. */
   endInboxRollingHash: `0x${string}`;
   proverId: `0x${string}`;
 };

yarn-project/ivc-integration/src/base_parity_inputs.test.ts

@@ -4,8 +4,8 @@
  *
  * Run with: BASE_PARITY_BENCH_DIR=./bench-out yarn workspace @aztec/ivc-integration test src/base_parity_inputs.test.ts
  *
- * The parity base/root circuits were replaced by the single variable-size InboxParity circuit (AZIP-22 Fast Inbox);
- * this benchmark now targets the 256-message rung (`InboxParity256`), matching the old base-parity circuit's size. The
+ * The parity base/root circuits were replaced by the single variable-size InboxParity circuit; this benchmark now
+ * targets the 256-message rung (`InboxParity256`), matching the old base-parity circuit's size. The
  * output files keep their legacy `parity_base.json` / `witness.gz` names because `ci_benchmark_ultrahonk_circuits.sh`
  * locates inputs as `${circuit_name}.json` with `circuit_name=parity_base`.
  */