Skip to content

Commit f80d7e4

Browse files
authored
fix(e2e): dedupe automine test cmds causing mass container-kill flakes (#24547)
Stacked on #24477. Fixes the 49-per-run automine FLAKEs reported there and on this PR's first run. **Root cause** (`yarn-project/end-to-end/bootstrap.sh`): the `tests` array listed the automine subdirectories explicitly and also kept the `src/automine/!(simulation)/**/*.test.ts` catch-all (a merge artifact from merging merge-train/fairies-v5 into mv/e2e-onchain-delivery-harness), so every nested automine test was emitted as two byte-identical cmds (268 jobs for 145 tests). Both copies run under the same docker container name. When the two copies overlap in time, the later one's docker_isolate force-removes the earlier one's live container (or wins the name-conflict retry added in #24477), the earlier test fails, and its automatic retry (which gets a fresh `NAME_POSTFIX`) passes: a deterministic FLAKED-with-code-0 for every overlapping pair, which is why the count sits near 49 on every run and why only `src/automine/**` flakes. When the copies do not overlap, the second is skipped by the test cache, hiding the duplication. The parent branch's "docker container name conflicts" were the same duplication seen from the other side. - Remove the seven redundant per-directory globs; the deduplicated unique cmd set is unchanged (verified byte-identical before/after, 145 automine jobs, zero duplicates in both `CI_FULL` modes).
1 parent 59d45f6 commit f80d7e4

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

yarn-project/end-to-end/bootstrap.sh

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,6 @@ function test_cmds {
5353
local tests=(
5454
# List all standalone and nested tests, except for the ones listed above.
5555
src/automine/*.test.ts
56-
src/automine/contracts/*.test.ts
57-
src/automine/contracts/deploy/*.test.ts
58-
src/automine/contracts/nested/*.test.ts
59-
src/automine/token/*.test.ts
60-
src/automine/accounts/*.test.ts
61-
src/automine/effects/*.test.ts
62-
src/automine/delivery/*.test.ts
6356
src/automine/!(simulation)/**/*.test.ts
6457
src/automine/simulation/!(avm_simulator).test.ts
6558
src/single-node/!(prover)/**/*.test.ts

0 commit comments

Comments
 (0)