refactor(aztec-nr)!: move messages::message_delivery to messages::delivery (#23875)

Pure module move to make reviewing
#23865 easier. In
#23865 we update the MessageDeliver builder API. Once this merges,
#23865 gets rebased on top so its diff shows only the API delta.

- Renames `aztec/src/messages/message_delivery.nr` to
`aztec/src/messages/delivery/mod.nr`
- Updates every import and doc-link site
- No behavior change and no API change;
- New `## TBD` migration note for the module move, and the existing TBD
`set_sender_for_tags` entry updated to the new path.
- Regenerated the two contract snapshots affected by the move
(`invalid_event` stderr, `token_contract` expanded).

Top of stack. Next is
#23865

---------

Co-authored-by: AztecBot <tech@aztec-labs.com>

Author: vezenovm

boxes/boxes/react/src/contracts/src/main.nr

@@ -4,7 +4,7 @@ use aztec::macros::aztec;
 contract BoxReact {
     use aztec::{
         macros::{functions::{external, initializer}, storage::storage},
-        messages::message_delivery::MessageDelivery,
+        messages::delivery::MessageDelivery,
         protocol::address::AztecAddress,
         state_vars::{Owned, PrivateMutable},
     };

boxes/boxes/vite/src/contracts/src/main.nr

@@ -4,7 +4,7 @@ use aztec::macros::aztec;
 contract BoxReact {
     use aztec::{
         macros::{functions::{external, initializer}, storage::storage},
-        messages::message_delivery::MessageDelivery,
+        messages::delivery::MessageDelivery,
         protocol::address::AztecAddress,
         state_vars::{Owned, PrivateMutable},
     };

docs/docs-developers/docs/aztec-nr/framework-description/events_and_logs.md

@@ -30,7 +30,7 @@ struct Transfer {
 In private functions, emit events using `self.emit()` and deliver them to recipients:
 
 ```rust
-use aztec::messages::message_delivery::MessageDelivery;
+use aztec::messages::delivery::MessageDelivery;
 
 #[external("private")]
 fn transfer(to: AztecAddress, amount: u128) {

docs/docs-developers/docs/aztec-nr/framework-description/note_delivery.md

@@ -22,7 +22,7 @@ When you create a note using state variables like `PrivateMutable`, `PrivateSet`
 ```rust
 #[aztec]
 pub contract PrivateToken {
-    use aztec::messages::message_delivery::MessageDelivery;
+    use aztec::messages::delivery::MessageDelivery;
 
     #[external("private")]
     fn mint(amount: u128, recipient: AztecAddress) {

docs/docs-developers/docs/aztec-nr/framework-description/state_variables.md

@@ -273,9 +273,9 @@ When working with private state variables, many operations return a `NoteMessage
 #### Delivery Methods
 
 Private notes need to be communicated to their recipients so they know the note exists and can use it. The [`NoteMessage`](pathname:///aztec-nr-api/#api_ref_version/noir_aztec/note/struct.NoteMessage) wrapper forces you to make an explicit choice about how this happens:
-  - [`MessageDelivery::onchain_constrained()`](pathname:///aztec-nr-api/#api_ref_version/noir_aztec/messages/message_delivery/global.MessageDelivery): Verified in the circuit (most secure, but highest cost) - Use when the sender cannot be trusted to deliver correctly (e.g., protocol fees, multisig config updates). **Warning:** Currently [not fully constrained](https://github.com/AztecProtocol/aztec-packages/issues/14565) - the log's tag is unconstrained.
-  - [`MessageDelivery::onchain_unconstrained()`](pathname:///aztec-nr-api/#api_ref_version/noir_aztec/messages/message_delivery/global.MessageDelivery): Message stored onchain but no guarantees on content - Use when the sender is incentivized to deliver correctly but may not have an offchain channel to the recipient.
-  - [`MessageDelivery::offchain()`](pathname:///aztec-nr-api/#api_ref_version/noir_aztec/messages/message_delivery/global.MessageDelivery): Lowest cost, no onchain data - Use when the sender and recipient can communicate and the sender is incentivized to deliver correctly.
+  - [`MessageDelivery::onchain_constrained()`](pathname:///aztec-nr-api/#api_ref_version/noir_aztec/messages/delivery/global.MessageDelivery): Verified in the circuit (most secure, but highest cost) - Use when the sender cannot be trusted to deliver correctly (e.g., protocol fees, multisig config updates). **Warning:** Currently [not fully constrained](https://github.com/AztecProtocol/aztec-packages/issues/14565) - the log's tag is unconstrained.
+  - [`MessageDelivery::onchain_unconstrained()`](pathname:///aztec-nr-api/#api_ref_version/noir_aztec/messages/delivery/global.MessageDelivery): Message stored onchain but no guarantees on content - Use when the sender is incentivized to deliver correctly but may not have an offchain channel to the recipient.
+  - [`MessageDelivery::offchain()`](pathname:///aztec-nr-api/#api_ref_version/noir_aztec/messages/delivery/global.MessageDelivery): Lowest cost, no onchain data - Use when the sender and recipient can communicate and the sender is incentivized to deliver correctly.
 
 #include_code note_delivery /noir-projects/noir-contracts/contracts/app/private_token_contract/src/main.nr rust
 

docs/docs-developers/docs/resources/migration_notes.md

@@ -9,6 +9,15 @@ Aztec is in active development. Each version may introduce breaking changes that
 
 ## TBD
 
+### [Aztec.nr] `messages::message_delivery` module moved to `messages::delivery`
+
+The `message_delivery` module has been renamed to `delivery`. Update imports accordingly:
+
+```diff
+- use aztec::messages::message_delivery::MessageDelivery;
++ use aztec::messages::delivery::MessageDelivery;
+```
+
 ### [Aztec.nr] `get_pending_tagged_logs` oracle interface updated (oracle version 28)
 
 The `aztec_utl_getPendingTaggedLogs` oracle now takes an additional `provided_secrets` parameter of type `EphemeralArray<ProvidedSecret>`. This lets apps pass tagging secrets that PXE cannot derive on its own (e.g. handshake-derived secrets) alongside the secrets PXE manages internally.
@@ -19,7 +28,7 @@ The `set_sender_for_tags` oracle has been removed. Contracts that used it to ove
 
 ```diff
 - use aztec::oracle::notes::set_sender_for_tags;
-+ use aztec::messages::message_delivery::MessageDelivery;
++ use aztec::messages::delivery::MessageDelivery;
 
 - unsafe { set_sender_for_tags(some_address) };
 - note.deliver(MessageDelivery::onchain_constrained());

docs/docs-developers/docs/tutorials/contract_tutorials/counter_contract.md

@@ -79,7 +79,7 @@ pub contract Counter {
 - `macros::{functions::{external, initializer}, storage::storage}`
   Imports the macros needed to define function types (`external`, `initializer`) and the `storage` macro for declaring contract storage structures.
 
-- `messages::message_delivery::MessageDelivery`
+- `messages::delivery::MessageDelivery`
   Imports `MessageDelivery` for specifying how note delivery should be handled (e.g., constrained onchain delivery).
 
 - `oracle::logging::debug_log_format`

docs/examples/contracts/bob_token_contract/src/main.nr

@@ -7,7 +7,7 @@ pub contract BobToken {
     // docs:end:start
     use aztec::{
         macros::{functions::{external, initializer, only_self}, storage::storage},
-        messages::message_delivery::MessageDelivery,
+        messages::delivery::MessageDelivery,
         protocol::address::AztecAddress,
         state_vars::{Map, Owned, PublicMutable},
     };

docs/examples/contracts/counter_contract/src/main.nr

@@ -7,7 +7,7 @@ pub contract Counter {
     // docs:start:imports
     use aztec::{
         macros::{functions::{external, initializer}, storage::storage},
-        messages::message_delivery::MessageDelivery,
+        messages::delivery::MessageDelivery,
         oracle::logging::debug_log_format,
         protocol::{address::AztecAddress, traits::ToField},
         state_vars::Owned,

docs/examples/contracts/nft/src/main.nr

@@ -10,7 +10,7 @@ pub contract NFTPunk {
         protocol::address::AztecAddress,
         state_vars::{DelayedPublicMutable, Map, Owned, PrivateSet, PublicImmutable},
     };
-    use aztec::messages::message_delivery::MessageDelivery;
+    use aztec::messages::delivery::MessageDelivery;
     use aztec::note::{
         note_getter_options::NoteGetterOptions, note_interface::NoteProperties,
         note_viewer_options::NoteViewerOptions,