From a5d7312c2b16a0f380ba4c964bea5fae40ca0073 Mon Sep 17 00:00:00 2001 From: AztecBot Date: Fri, 29 Aug 2025 08:09:57 +0000 Subject: [PATCH 01/10] chore: Update noir-repo-ref to nightly-2025-08-29 --- noir/noir-repo-ref | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/noir/noir-repo-ref b/noir/noir-repo-ref index a733a6e85d10..12e2c71c06ea 100644 --- a/noir/noir-repo-ref +++ b/noir/noir-repo-ref @@ -1 +1 @@ -nightly-2025-08-28 +nightly-2025-08-29 From 4c6072fe879a0d077480000d6e5c2bccee5b5aa6 Mon Sep 17 00:00:00 2001 From: AztecBot Date: Sat, 30 Aug 2025 08:09:24 +0000 Subject: [PATCH 02/10] chore: Update noir-repo-ref to nightly-2025-08-30 --- noir/noir-repo-ref | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/noir/noir-repo-ref b/noir/noir-repo-ref index 12e2c71c06ea..38aa33293e55 100644 --- a/noir/noir-repo-ref +++ b/noir/noir-repo-ref @@ -1 +1 @@ -nightly-2025-08-29 +nightly-2025-08-30 From 540dc5c95aed73f21a55bbc749ace570c2884952 Mon Sep 17 00:00:00 2001 From: AztecBot Date: Sun, 31 Aug 2025 08:09:40 +0000 Subject: [PATCH 03/10] chore: Update noir-repo-ref to nightly-2025-08-31 --- noir/noir-repo-ref | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/noir/noir-repo-ref b/noir/noir-repo-ref index 38aa33293e55..d89e393badfe 100644 --- a/noir/noir-repo-ref +++ b/noir/noir-repo-ref @@ -1 +1 @@ -nightly-2025-08-30 +nightly-2025-08-31 From 01ffc7141723dfdde05e325c7215c841f903de59 Mon Sep 17 00:00:00 2001 From: AztecBot Date: Mon, 1 Sep 2025 08:11:03 +0000 Subject: [PATCH 04/10] chore: Update noir-repo-ref to nightly-2025-09-01 --- noir/noir-repo-ref | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/noir/noir-repo-ref b/noir/noir-repo-ref index d89e393badfe..10423e5ca6b0 100644 --- a/noir/noir-repo-ref +++ b/noir/noir-repo-ref @@ -1 +1 @@ -nightly-2025-08-31 +nightly-2025-09-01 From 4b310208579fedc80fab81496a3458d3822870a3 Mon Sep 17 00:00:00 2001 From: Tom French <15848336+TomAFrench@users.noreply.github.com> Date: Mon, 1 Sep 2025 17:54:40 +0000 Subject: [PATCH 05/10] . --- avm-transpiler/Cargo.lock | 1 + 1 file changed, 1 insertion(+) diff --git a/avm-transpiler/Cargo.lock b/avm-transpiler/Cargo.lock index e39bb5b5271f..2836b56f7961 100644 --- a/avm-transpiler/Cargo.lock +++ b/avm-transpiler/Cargo.lock @@ -1277,6 +1277,7 @@ dependencies = [ "fm", "fxhash", "im", + "indexmap 2.10.0", "iter-extended", "noirc_errors", "noirc_frontend", From b7495fb3cf9a5408229754e476290a7a587de4d7 Mon Sep 17 00:00:00 2001 From: Tom French <15848336+TomAFrench@users.noreply.github.com> Date: Mon, 1 Sep 2025 19:03:55 +0000 Subject: [PATCH 06/10] . --- .../src/private_kernel_inner.nr | 36 ++++++++++--------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/private_kernel_inner.nr b/noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/private_kernel_inner.nr index f1792876c43e..5e315f3b6bdf 100644 --- a/noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/private_kernel_inner.nr +++ b/noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/private_kernel_inner.nr @@ -60,26 +60,28 @@ impl PrivateKernelInnerCircuitPrivateInputs { start_private_call_stack_length - 1]; - private_call_data_validator.verify_proof(false /* is_first_app */); - private_call_data_validator.validate_common( - self.previous_kernel.public_inputs.constants.protocol_contract_tree_root, - ); - private_call_data_validator.validate_against_call_request(call_request); - private_call_data_validator.validate_against_previous_kernel(self.previous_kernel.public_inputs); - - // Generate output. - // Safety: The output is validated below by PrivateKernelCircuitOutputValidator. - let output = unsafe { self.generate_output() }; - - // Validate output. - if dep::types::validate::should_validate_output() { - PrivateKernelCircuitOutputValidator::new(output).validate_as_inner_call( + private_call_data_validator.verify_proof(false /* is_first_app */); + private_call_data_validator.validate_common( + self.previous_kernel.public_inputs.constants.protocol_contract_tree_root, + ); + private_call_data_validator.validate_against_call_request(call_request); + private_call_data_validator.validate_against_previous_kernel( self.previous_kernel.public_inputs, - self.private_call, ); + + // Generate output. + // Safety: The output is validated below by PrivateKernelCircuitOutputValidator. + let output = unsafe { self.generate_output() }; + + // Validate output. + if dep::types::validate::should_validate_output() { + PrivateKernelCircuitOutputValidator::new(output).validate_as_inner_call( + self.previous_kernel.public_inputs, + self.private_call, + ); + } + output } - output -} } mod tests { From 0129c4e7e1f349d55055772537f553fab23b50a6 Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Mon, 1 Sep 2025 16:55:02 -0300 Subject: [PATCH 07/10] Try with 74d9f80cbd20bb5f11b61f2fdea65d707809b63b --- noir/noir-repo-ref | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/noir/noir-repo-ref b/noir/noir-repo-ref index 10423e5ca6b0..bfe5c67ee384 100644 --- a/noir/noir-repo-ref +++ b/noir/noir-repo-ref @@ -1 +1 @@ -nightly-2025-09-01 +74d9f80cbd20bb5f11b61f2fdea65d707809b63b From ca19e5d42bc2dd3ee55faba88c7eaf6abd36c434 Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Tue, 2 Sep 2025 09:24:26 -0300 Subject: [PATCH 08/10] nargo fmt --- .../src/private_kernel_inner.nr | 36 +++++++++---------- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/private_kernel_inner.nr b/noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/private_kernel_inner.nr index 5e315f3b6bdf..f1792876c43e 100644 --- a/noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/private_kernel_inner.nr +++ b/noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/private_kernel_inner.nr @@ -60,28 +60,26 @@ impl PrivateKernelInnerCircuitPrivateInputs { start_private_call_stack_length - 1]; - private_call_data_validator.verify_proof(false /* is_first_app */); - private_call_data_validator.validate_common( - self.previous_kernel.public_inputs.constants.protocol_contract_tree_root, - ); - private_call_data_validator.validate_against_call_request(call_request); - private_call_data_validator.validate_against_previous_kernel( + private_call_data_validator.verify_proof(false /* is_first_app */); + private_call_data_validator.validate_common( + self.previous_kernel.public_inputs.constants.protocol_contract_tree_root, + ); + private_call_data_validator.validate_against_call_request(call_request); + private_call_data_validator.validate_against_previous_kernel(self.previous_kernel.public_inputs); + + // Generate output. + // Safety: The output is validated below by PrivateKernelCircuitOutputValidator. + let output = unsafe { self.generate_output() }; + + // Validate output. + if dep::types::validate::should_validate_output() { + PrivateKernelCircuitOutputValidator::new(output).validate_as_inner_call( self.previous_kernel.public_inputs, + self.private_call, ); - - // Generate output. - // Safety: The output is validated below by PrivateKernelCircuitOutputValidator. - let output = unsafe { self.generate_output() }; - - // Validate output. - if dep::types::validate::should_validate_output() { - PrivateKernelCircuitOutputValidator::new(output).validate_as_inner_call( - self.previous_kernel.public_inputs, - self.private_call, - ); - } - output } + output +} } mod tests { From 99adcf616c178cefc448f98f2f7507686a59117a Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Tue, 2 Sep 2025 09:52:12 -0300 Subject: [PATCH 09/10] Try with 48327c0df00ec3b355bf413974ced42367d1dafe --- noir/noir-repo-ref | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/noir/noir-repo-ref b/noir/noir-repo-ref index bfe5c67ee384..e455fecae58e 100644 --- a/noir/noir-repo-ref +++ b/noir/noir-repo-ref @@ -1 +1 @@ -74d9f80cbd20bb5f11b61f2fdea65d707809b63b +48327c0df00ec3b355bf413974ced42367d1dafe From ad42d784168d50e9ca9ec10f330795c62e38645a Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Tue, 2 Sep 2025 10:20:51 -0300 Subject: [PATCH 10/10] fix --- avm-transpiler/Cargo.lock | 1 - 1 file changed, 1 deletion(-) diff --git a/avm-transpiler/Cargo.lock b/avm-transpiler/Cargo.lock index 2836b56f7961..e39bb5b5271f 100644 --- a/avm-transpiler/Cargo.lock +++ b/avm-transpiler/Cargo.lock @@ -1277,7 +1277,6 @@ dependencies = [ "fm", "fxhash", "im", - "indexmap 2.10.0", "iter-extended", "noirc_errors", "noirc_frontend",