chore: Validate L1 config in ts-land#16647
Merged
spalladino merged 1 commit intonextfrom Aug 29, 2025
Merged
Conversation
spalladino
requested review from
LHerskind,
Maddiaa0 and
just-mitch
as code owners
spalladino
force-pushed
the
palla/slash-improvements
branch
3 times, most recently
from
61c592a to
c5fa2d3
Compare
Base automatically changed from
palla/slash-improvements
to
palla/slash-settings
August 29, 2025 16:59
spalladino
force-pushed
the
palla/slash-settings
branch
from
0b75251 to
cc519f7
Compare
spalladino
force-pushed
the
palla/validate-l1-config
branch
from
569b5ed to
507e82f
Compare
spalladino
changed the base branch from
palla/slash-settings
to
palla/slash-improvements-2
just-mitch
approved these changes
Aug 29, 2025
spalladino
force-pushed
the
palla/validate-l1-config
branch
3 times, most recently
from
70e1164 to
b15ac7e
Compare
spalladino
added
the
ci-no-fail-fast
spalladino
force-pushed
the
palla/validate-l1-config
branch
from
b15ac7e to
3815071
Compare
spalladino
force-pushed
the
palla/validate-l1-config
branch
3 times, most recently
from
8cdbc1f to
0798387
Compare
Validates L1 config _before_ trying to deploy L1 contracts, so we can get an early warning if the deployment would fail. Also, changes the slashRoundSize setting to slashRoundSizeInEpochs, to force it to be a multiple of epochs, as required by the slash proposer. It also makes the quorum settings optional, defaulting them to half the round size plus one. This should make configuration easier.
spalladino
force-pushed
the
palla/validate-l1-config
branch
from
0798387 to
e4a7abd
Compare
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validates L1 config before trying to deploy L1 contracts, so we can get an early warning if the deployment would fail.
Also, changes the slashRoundSize setting to slashRoundSizeInEpochs, to force it to be a multiple of epochs, as required by the slash proposer. It also makes the quorum settings optional, defaulting them to half the round size plus one. This should make configuration easier.