fix: in avm cpp sim put counters (nullifier, notehash, msg) into a stack to be rolled back on error#16665
Merged
fix: in avm cpp sim put counters (nullifier, notehash, msg) into a stack to be rolled back on error#16665
Conversation
Contributor
Author
This was referenced Aug 29, 2025
dbanks12
force-pushed
the
db/misc-fixes-sideeffects
branch
from
78f4786 to
3c874e4
Compare
dbanks12
force-pushed
the
db/counterstack
branch
from
a35c9d0 to
a3aae5a
Compare
dbanks12
requested review from
IlyasRidhuan,
fcarreiro and
jeanmon
as code owners
This was referenced Aug 29, 2025
fcarreiro
approved these changes
Sep 1, 2025
dbanks12
force-pushed
the
db/misc-fixes-sideeffects
branch
from
3c874e4 to
953f475
Compare
dbanks12
force-pushed
the
db/counterstack
branch
2 times, most recently
from
058fb20 to
768e417
Compare
…ack to be rolled back on error
dbanks12
force-pushed
the
db/counterstack
branch
from
768e417 to
4c886c2
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
…ack to be rolled back on error (#16665)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AVM cpp simulator needs to rollback counters on error/revert. This PR introduces a stack of counters in the concrete DB.