fix: Do not aggregate validator offenses across epochs in a vote#16695
Merged
spalladino merged 1 commit intonextfrom Sep 2, 2025
Merged
fix: Do not aggregate validator offenses across epochs in a vote#16695spalladino merged 1 commit intonextfrom
spalladino merged 1 commit intonextfrom
Conversation
spalladino
force-pushed
the
palla/fix-tmnt-233
branch
2 times, most recently
from
7680350 to
86b0694
Compare
just-mitch
reviewed
Sep 2, 2025
just-mitch
approved these changes
Sep 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
When a validator shows up in multiple committees within a round, we used to aggregate all offenses and vote for them only once. This had side effects such as that, if the slash amount for each epoch was the max slashable amount, they would get slashed only once. This commit changes it so each appearance of a validator in a slashing round is voted for independently, based on the offenses of that validator for that specific round. Fixes https://linear.app/aztec-labs/issue/TMNT-233/more-clearly-define-expected-behaviour
spalladino
force-pushed
the
palla/fix-tmnt-233
branch
from
86b0694 to
db6d18b
Compare
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a validator shows up in multiple committees within a round, we used to aggregate all offenses and vote for them only once. This had side effects such as that, if the slash amount for each epoch was the max slashable amount, they would get slashed only once.
This commit changes it so each appearance of a validator in a slashing round is voted for independently, based on the offenses of that validator for that specific round.
Fixes https://linear.app/aztec-labs/issue/TMNT-233/more-clearly-define-expected-behaviour