Conversation
alexghr
changed the title
alexghr
commented
Sep 2, 2025
Comment on lines
-16
to
-19
| // Same as pino.stdTimeFunctions.isoTime but uses "timestamp" key instead of "time" | ||
| timestamp(): string { | ||
| return `,"timestamp":"${new Date(Date.now()).toISOString()}"`; | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
This doesn't work as expected. GKE adds its own timestamp field.
Contributor
There was a problem hiding this comment.
Just wondering: should we keep the system timestamp as well, so we know the exact time from the perspective of the node process for the log?
spalladino
approved these changes
Sep 2, 2025
Comment on lines
-16
to
-19
| // Same as pino.stdTimeFunctions.isoTime but uses "timestamp" key instead of "time" | ||
| timestamp(): string { | ||
| return `,"timestamp":"${new Date(Date.now()).toISOString()}"`; | ||
| }, |
Contributor
There was a problem hiding this comment.
Just wondering: should we keep the system timestamp as well, so we know the exact time from the perspective of the node process for the log?
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close TMNT-236