feat!: allow consuming l1-to-l2 message in the same block#16704
Merged
spalladino merged 1 commit intopalla/l1-to-l2-message-proving-v2from Sep 2, 2025
Merged
Conversation
spalladino
approved these changes
Sep 2, 2025
Contributor
spalladino
left a comment
spalladino
left a comment
There was a problem hiding this comment.
Looks great, thanks @LeilaWang!!
| tx, | ||
| provingState.globalVariables, | ||
| provingState.l1ToL2MessageTreeSnapshot, | ||
| provingState.l1ToL2MessageTreeSnapshotAfterInsertion, |
Contributor
There was a problem hiding this comment.
Can't believe this was the only change needed in the orchestrator
spalladino
added a commit
that referenced
this pull request
Sep 2, 2025
Co-authored-by: iLeila Wang <leizciw@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
…ck (#16375) Fixes issue where proving fails for a tx that consumes an l1 to l2 message that was bridged on the same block as the tx is mined. The prover was failing to add the messages to the tree _before_ running tx public function simulation, so txs didnt have access to the messages from that block, so their execution reverted, yielding a different end state root. See also #16704 Fixes #16675
mralj
pushed a commit
that referenced
this pull request
Oct 13, 2025
Co-authored-by: iLeila Wang <leizciw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now feed the new l1-to-l2 message tree root to the avm, allowing the public functions to consume the messages that are going to be inserted to the tree in the block root rollup.