Skip to content

feat: remove isRewardClaimable#21765

Merged
LHerskind merged 1 commit intonextfrom
lh/tmnt-513-remove-reward-lock-from-rollup
Apr 11, 2026
Merged

feat: remove isRewardClaimable#21765
LHerskind merged 1 commit intonextfrom
lh/tmnt-513-remove-reward-lock-from-rollup

Conversation

@LHerskind
Copy link
Copy Markdown
Contributor

Summary

Remove the reward-claimability lock from l1-contracts.

Reward claims no longer depend on a governance-controlled flag or an unlock timestamp. Claims now succeed or fail only based on the existing reward/accounting rules, such as whether rewards exist and whether prover claims are past the proof deadline.

What Changed

  • Removed isRewardsClaimable and earliestRewardsClaimableTimestamp from reward storage.
  • Removed the related ABI/config surface:
    • getters
    • setter
    • event
    • errors
    • rollup forwarding methods
  • Removed reward-claimability checks from:
    • claimSequencerRewards
    • claimProverRewards
    • FlushRewarder.claimRewards
  • Removed deploy/test config plumbing for the unlock timestamp.
  • Rewrote the affected tests to cover the simplified behavior directly.
  • Updated the current operator docs for claiming rewards.

@LHerskind LHerskind force-pushed the lh/tmnt-514-remove-useless-istxsenabled branch from 1d42c35 to 2db5118 Compare March 19, 2026 09:17
@LHerskind LHerskind force-pushed the lh/tmnt-513-remove-reward-lock-from-rollup branch from 1e34ffe to 50e141b Compare March 19, 2026 09:22
@LHerskind LHerskind force-pushed the lh/tmnt-514-remove-useless-istxsenabled branch from 2db5118 to 7da2ecf Compare March 19, 2026 15:18
@LHerskind LHerskind force-pushed the lh/tmnt-513-remove-reward-lock-from-rollup branch from 50e141b to becb2f3 Compare March 19, 2026 15:37
@LHerskind LHerskind marked this pull request as ready for review March 23, 2026 11:47
@LHerskind LHerskind force-pushed the lh/tmnt-514-remove-useless-istxsenabled branch from 7da2ecf to d34d040 Compare March 24, 2026 19:30
@LHerskind LHerskind force-pushed the lh/tmnt-513-remove-reward-lock-from-rollup branch from becb2f3 to dc05d80 Compare March 24, 2026 21:36
Copy link
Copy Markdown
Member

@Maddiaa0 Maddiaa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simply lovely

@LHerskind LHerskind force-pushed the lh/tmnt-514-remove-useless-istxsenabled branch 2 times, most recently from a4abea5 to e6944cb Compare April 10, 2026 09:50
Base automatically changed from lh/tmnt-514-remove-useless-istxsenabled to next April 10, 2026 16:00
@LHerskind LHerskind force-pushed the lh/tmnt-513-remove-reward-lock-from-rollup branch from dc05d80 to 7e6c33f Compare April 11, 2026 19:28
@LHerskind LHerskind added this pull request to the merge queue Apr 11, 2026
Merged via the queue into next with commit e88ecdf Apr 11, 2026
20 checks passed
@LHerskind LHerskind deleted the lh/tmnt-513-remove-reward-lock-from-rollup branch April 11, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants