Skip to content

fix: wrap debug pairing point checks in try-catch to fix nightly debug build #22040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AztecBot wants to merge 1 commit into
base: next
Choose a base branch
from
+13 −4
Draft

fix: wrap debug pairing point checks in try-catch to fix nightly debug build #22040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions barretenberg/cpp/src/barretenberg/stdlib/primitives/pairing_points.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ template <typename Curve> struct PairingPoints {
}

#ifndef NDEBUG
bb::PairingPoints<typename Curve::NativeCurve> native_pp(P0().get_value(), P1().get_value());
info("Are Pairing Points with tag ", tag_index, " valid? ", native_pp.check() ? "true" : "false");
try {
bb::PairingPoints<typename Curve::NativeCurve> native_pp(P0().get_value(), P1().get_value());
info("Are Pairing Points with tag ", tag_index, " valid? ", native_pp.check() ? "true" : "false");
} catch (const std::exception&) {
info("Are Pairing Points with tag ", tag_index, " valid? false (point not on curve)");
}
#endif
}

Expand Down Expand Up @@ -210,8 +214,13 @@ template <typename Curve> struct PairingPoints {
}

#ifndef NDEBUG
bb::PairingPoints<typename Curve::NativeCurve> native_pp(P0().get_value(), P1().get_value());
info("Are aggregated Pairing Points with tag ", tag_index, " valid? ", native_pp.check() ? "true" : "false");
try {
bb::PairingPoints<typename Curve::NativeCurve> native_pp(P0().get_value(), P1().get_value());
info(
"Are aggregated Pairing Points with tag ", tag_index, " valid? ", native_pp.check() ? "true" : "false");
} catch (const std::exception&) {
info("Are aggregated Pairing Points with tag ", tag_index, " valid? false (point not on curve)");
}
#endif
}

Expand Down
Loading