fix: remove constexpr from functions using std::vector (ASAN _GLIBCXX_DEBUG compat)#22259
Closed
AztecBot wants to merge 1 commit intomerge-train/barretenbergfrom
Closed
fix: remove constexpr from functions using std::vector (ASAN _GLIBCXX_DEBUG compat)#22259AztecBot wants to merge 1 commit intomerge-train/barretenbergfrom
AztecBot wants to merge 1 commit intomerge-train/barretenbergfrom
Conversation
AztecBot
added
ci-draft
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
constexprfromhash_to_curveandECCVMFixedVK::get_all()— both usestd::vectorwhich is non-literal under_GLIBCXX_DEBUG(added in chore: enable _GLIBCXX_DEBUG in debug build presets #22218), breaking the ASAN build.Verification
asan-fastpreset: builds cleanClaudeBox log: https://claudebox.work/s/501e5c6e06a49c75?run=1