Skip to content

chore: crypto primitives external audit response 1 #22272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnathan79717 wants to merge 1 commit into
base: merge-train/barretenberg
Choose a base branch
from
+14 −0
Open

chore: crypto primitives external audit response 1 #22272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions barretenberg/cpp/scripts/wasmtime.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ set -eu
export WASMTIME_BACKTRACE_DETAILS=1
exec wasmtime run \
-Wthreads=y \
-Wunknown-imports-trap=y \
-Sthreads=y \
${HARDWARE_CONCURRENCY:+--env HARDWARE_CONCURRENCY} \
--env HOME \
Expand Down
13 changes: 13 additions & 0 deletions barretenberg/cpp/src/barretenberg/env/throw_or_abort_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
// In WASM builds, throw_or_abort_impl is provided by the JavaScript environment
// (declared as WASM_IMPORT in throw_or_abort_impl.hpp). The JS implementation
// throws a catchable JS Error with the error message.
//
// For non-JS WASM runtimes (wasmtime), the import must also be provided.
// See barretenberg/cpp/scripts/wasmtime.sh for the wasmtime configuration.
//
// We guard out the C++ definition so the JS import is used instead of being
// shadowed by the local definition (which would call std::abort).
#ifndef __wasm__

#include "barretenberg/common/log.hpp"
#include "barretenberg/common/wasm_export.hpp"
#include <stdexcept>
Expand Down Expand Up @@ -27,3 +38,5 @@ WASM_EXPORT void throw_or_abort_impl [[noreturn]] (const char* err)
abort_with_message(err);
#endif
}

#endif // !__wasm__
Loading