Skip to content

chore: UB updates#22308

Merged
ledwards2225 merged 4 commits intomerge-train/barretenbergfrom
lde/ub-updates
Apr 7, 2026
Merged

chore: UB updates#22308
ledwards2225 merged 4 commits intomerge-train/barretenbergfrom
lde/ub-updates

Conversation

@ledwards2225
Copy link
Copy Markdown
Contributor

Fixes the following from UB meta issue:

  • F11 (zk_sumcheck_data.hpp) — Signed 1 << n is UB when n≥31; changed to 1UL <<
  • F10 (rom_table.cpp, ram_table.cpp, twin_rom_table.cpp, databus.cpp) — OOB vector access after context->failure() soft fail; added early returns
  • F9 (field_declarations.hpp, field_impl_x64.hpp) — asm_self_* functions write through const& which is UB; changed to mutable ref

@ledwards2225 ledwards2225 marked this pull request as ready for review April 3, 2026 20:11
@ledwards2225 ledwards2225 requested a review from notnotraju April 3, 2026 20:11
@ledwards2225 ledwards2225 merged commit 97e3802 into merge-train/barretenberg Apr 7, 2026
12 checks passed
@ledwards2225 ledwards2225 deleted the lde/ub-updates branch April 7, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants