fix: corrupt low-order bytes in batch verifier test + skip WASM non-canonical test#22333
Merged
ludamad merged 1 commit intomerge-train/barretenbergfrom Apr 6, 2026
Merged
Conversation
…nical field encoding
AztecBot
added
ci-draft
ludamad
approved these changes
Apr 6, 2026
AztecBot
changed the title
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 6, 2026
BEGIN_COMMIT_OVERRIDE fix: reject VK with log_circuit_size=0 in UltraKeccak verifier (#22319) chore: merkle tree audit 2 (#21475) fix: graceful failures in verifier code paths + other fixes (#22311) fix: Fr::from_u64 big-endian encoding to match C++ msgpack format (#22233) fix: corrupt low-order bytes in batch verifier test to avoid non-canonical field encoding (#22333) fix: skip MsgpackRejectsNonCanonical test in WASM builds (#22335) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two CI failures in
merge-train/barretenbergcaused by the interaction of #22233 (Fr::from_u64 big-endian encoding) and #22311 (strict non-canonical field validation).Fix 1:
batch_verifier.test.ts— corrupt low-order bytesThe
corruptProofFields()test helper was flipping high-order bytes (indices 0,1) of field elements, creating values exceeding the BN254 Fr modulus. The strict validation now rejects these at deserialization time withnon-canonical encoding (value >= modulus)before they reach the verifier.Fix: Flip low-order bytes (indices 30,31) instead — still corrupts the proof but keeps field values canonical.
Fix 2:
PrimeFieldTest/MsgpackRejectsNonCanonical— skip in WASMThe test uses
EXPECT_THROWto verify non-canonical field rejection, but WASM builds defineBB_NO_EXCEPTIONS, sothrow_or_abortcallsabort()instead of throwing — crashing the test runner.Fix: Wrap the test with
#ifndef BB_NO_EXCEPTIONSand add aGTEST_SKIP()fallback, matching the existing pattern inc_bind_exception.test.cpp.Test plan
batch_verifier.test.ts— all 4 tests pass locallyecc_tests --gtest_filter=*MsgpackRejectsNonCanonical*— all 6 field types pass on native