fix: skip heavy recursion tests in debug builds, keep one for assertion coverage#22389
Merged
federicobarbacovi merged 1 commit intomerge-train/barretenbergfrom Apr 10, 2026
Merged
Conversation
AztecBot
added
ci-draft
AztecBot
force-pushed
the
claudebox/fix-bb-debug-build
branch
from
03bc79a to
5099c55
Compare
AztecBot
changed the title
AztecBot
force-pushed
the
claudebox/fix-bb-debug-build
branch
from
5099c55 to
5f8202e
Compare
federicobarbacovi
changed the base branch from
next
to
merge-train/barretenberg
AztecBot
changed the title
AztecBot
force-pushed
the
claudebox/fix-bb-debug-build
branch
from
5f8202e to
eed2056
Compare
…on coverage Skip AvmRecursionInnerCircuitTests in debug builds (timed out at 600s in nightly). Same pattern as HonkRecursionConstraintTest and ChonkRecursionConstraintTest. Reinstate HonkRecursionConstraintTestWithoutPredicate/1.GenerateVK FromConstraints (241s, well within timeout) so the debug-only native_verification_debug code path in honk_recursion_constraint.cpp is still exercised. This is the only debug assertion unique to these skipped suites — all others either fire on the happy path (covered by other tests) or are disabled via BB_DISABLE_ASSERTS() in the test.
AztecBot
changed the title
AztecBot
force-pushed
the
claudebox/fix-bb-debug-build
branch
from
eed2056 to
5527afc
Compare
federicobarbacovi
approved these changes
Apr 10, 2026
federicobarbacovi
merged commit d0385aa
into
merge-train/barretenberg
16 of 20 checks passed
This was referenced Apr 10, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 13, 2026
BEGIN_COMMIT_OVERRIDE fix: skip heavy recursion tests in debug builds (#22446) fix: add clear error for unsatisfiable ACIR AssertZero opcode (#22417) feat: enforce accumulator_not_empty = 0 at ECCVM lagrange_first row (#22461) fix: skip heavy recursion tests in debug builds, keep one for assertion coverage (#22389) fix: external audit fixes for Pedersen (#22434) chore!: fix BASE off-by-one in create_small_range_constraint in theta step of keccak (#22404) fix: external audit fixes for Keccak (#22436) fix: external audit fixes for BLAKE (#22443) chore: misc hash gadget updates (#22452) END_COMMIT_OVERRIDE
critesjosh
pushed a commit
that referenced
this pull request
Apr 14, 2026
…on coverage (#22389) ## Summary Fixes nightly barretenberg debug build failure (CI run https://github.com/AztecProtocol/aztec-packages/actions/runs/24228497408). **Root cause:** `AvmRecursionInnerCircuitTests.Tampering` from `vm2_tests` timed out at 600s. CI log: http://ci.aztec-labs.com/ee4d306df4cbfd3c **Fix:** 1. Add `AvmRecursionInnerCircuitTests` to the debug build skip list (matching PR #22446 pattern) 2. Reinstate `HonkRecursionConstraintTestWithoutPredicate/1.GenerateVKFromConstraints` (241s, well within timeout) so the debug-only `native_verification_debug` code path in `honk_recursion_constraint.cpp:126` is still exercised **Debug assertion audit of all skipped suites:** - `HonkRecursionConstraintTest`: The only unique debug code is `native_verification_debug` (`#ifndef NDEBUG`, line 126) — a native side-verification sanity check. All tampering tests call `BB_DISABLE_ASSERTS()` so no debug assertions fire there. We keep `/1.GenerateVKFromConstraints` to cover this. - `ChonkRecursionConstraintTest`: All `BB_ASSERT_DEBUG` in `chonk.cpp` are disabled by `BB_DISABLE_ASSERTS()` in the test. `ChonkTests` tampering (separate binary, not skipped) still runs. - `AvmRecursionInnerCircuitTests`: Only `BB_ASSERT_LTE` (circuit size bounds) which is hit on the happy path by `AvmRecursiveTests`. ClaudeBox log: https://claudebox.work/s/7d8cbad767a56122?run=5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes nightly barretenberg debug build failure (CI run https://github.com/AztecProtocol/aztec-packages/actions/runs/24228497408).
Root cause:
AvmRecursionInnerCircuitTests.Tamperingfromvm2_teststimed out at 600s. CI log: http://ci.aztec-labs.com/ee4d306df4cbfd3cFix:
AvmRecursionInnerCircuitTeststo the debug build skip list (matching PR fix: skip heavy recursion tests in debug builds #22446 pattern)HonkRecursionConstraintTestWithoutPredicate/1.GenerateVKFromConstraints(241s, well within timeout) so the debug-onlynative_verification_debugcode path inhonk_recursion_constraint.cpp:126is still exercisedDebug assertion audit of all skipped suites:
HonkRecursionConstraintTest: The only unique debug code isnative_verification_debug(#ifndef NDEBUG, line 126) — a native side-verification sanity check. All tampering tests callBB_DISABLE_ASSERTS()so no debug assertions fire there. We keep/1.GenerateVKFromConstraintsto cover this.ChonkRecursionConstraintTest: AllBB_ASSERT_DEBUGinchonk.cppare disabled byBB_DISABLE_ASSERTS()in the test.ChonkTeststampering (separate binary, not skipped) still runs.AvmRecursionInnerCircuitTests: OnlyBB_ASSERT_LTE(circuit size bounds) which is hit on the happy path byAvmRecursiveTests.ClaudeBox log: https://claudebox.work/s/7d8cbad767a56122?run=5