Skip to content

fix: skip heavy recursion tests in nightly debug builds#22484

Draft
AztecBot wants to merge 1 commit intonextfrom
claudebox/fix-bb-debug-build-nightly
Draft

fix: skip heavy recursion tests in nightly debug builds#22484
AztecBot wants to merge 1 commit intonextfrom
claudebox/fix-bb-debug-build-nightly

Conversation

@AztecBot
Copy link
Copy Markdown
Collaborator

Summary

Fixes the recurring nightly barretenberg debug build failure caused by test timeouts.

Root cause: HonkRecursionConstraintTest, ChonkRecursionConstraintTest, and AvmRecursionInnerCircuitTests take 400-600s in debug builds, hitting the 600s default timeout. These suites build full recursive circuits which are extremely slow without compiler optimizations.

Fix (cherry-picked from merge-train/barretenberg PRs #22446 and #22389):

  1. Skip HonkRecursionConstraintTest, ChonkRecursionConstraintTest, and AvmRecursionInnerCircuitTests suites in debug builds
  2. Keep HonkRecursionConstraintTestWithoutPredicate/1.GenerateVKFromConstraints (241s, well within timeout) so the debug-only native_verification_debug code path in honk_recursion_constraint.cpp is still exercised
  3. Add BB_DISABLE_ASSERTS() to ChonkRecursionConstraintTest::GenerateRecursiveChonkVerifierVKFromConstraints to match the pattern used in other heavy tests

Debug assertion coverage audit:

  • HonkRecursionConstraintTest: The retained /1.GenerateVKFromConstraints test covers the native_verification_debug path (#ifndef NDEBUG)
  • ChonkRecursionConstraintTest: All BB_ASSERT_DEBUG in chonk.cpp are disabled by BB_DISABLE_ASSERTS(). ChonkTests tampering (separate binary, not skipped) still runs
  • AvmRecursionInnerCircuitTests: BB_ASSERT_LTE (circuit size bounds) is hit on the happy path by AvmRecursiveTests

Failed nightly run: https://github.com/AztecProtocol/aztec-packages/actions/runs/24228497408

ClaudeBox log: https://claudebox.work/s/ad59d50075fdf2f7?run=1

@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels Apr 11, 2026
@AztecBot
Copy link
Copy Markdown
Collaborator Author

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/6edfa65a39db1ef9�6edfa65a39db1ef98;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_offchain_payment.test.ts (56s) (code: 0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant