fix: stabilize blacklist token shielding test after time warp#22487
Closed
AztecBot wants to merge 1 commit intomerge-train/barretenbergfrom
Closed
fix: stabilize blacklist token shielding test after time warp#22487AztecBot wants to merge 1 commit intomerge-train/barretenbergfrom
AztecBot wants to merge 1 commit intomerge-train/barretenbergfrom
Conversation
Force PXE to sync the warped block by adding a simulate call after crossTimestampOfChange(). Under heavy CI load (64+ parallel tests), the PXE block sync may silently fail, leaving a stale anchor block with a pre-warp timestamp. This causes 'Invalid expiration timestamp' when the next transaction is sent (expiration = stale_ts + 86400 is barely past the node's next-slot timestamp after the warp). Also marks the test as flaky in .test_patterns.yml for the specific error_regex as a safety net.
AztecBot
added
ci-draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI failure in
merge-train/barretenbergwheree2e_blacklist_token_contract/shielding.test.tsfails with "Invalid expiration timestamp" on all 8 tests.Root Cause
After PR #22084 changed the
CheatCodes.warpL2TimeAtLeastByAPI to usenode.mineBlock(), there's a timing issue under heavy CI load (64+ parallel tests). After the time warp + mineBlock, the PXE's block sync may not pick up the warped block before the nextsend()call runsproveTx. If the PXE uses a stale anchor block (pre-warp timestamp), the tx expiration =stale_ts + MAX_TX_LIFETIMEfalls barely past the node's current slot timestamp, causing validation failure.The test passes reliably when run in isolation.
Fix
simulate()call aftercrossTimestampOfChange()to force the PXE to sync the latest block before subsequent transactions. This ensures the PXE always has the warped block as its anchor..test_patterns.ymlwitherror_regex: "Invalid expiration timestamp"as a safety net.Test Plan
ClaudeBox log: https://claudebox.work/s/87723e85fc6130ed?run=1