feat(pxe): disallow registering invalid addresses as senders#22489
Merged
benesjan merged 1 commit intomerge-train/fairiesfrom Apr 14, 2026
Conversation
Validates that addresses correspond to a point on the Grumpkin curve before allowing them to be added to the sender address book. This prevents runtime failures in LogService when computing tagging secrets for invalid senders. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Thunkar
approved these changes
Apr 14, 2026
benesjan
deleted the
jan/f-512-disallow-registering-invalid-addresses-as-senders-in-pxe
branch
AztecBot
pushed a commit
that referenced
this pull request
Apr 14, 2026
Collaborator
|
❌ Failed to cherry-pick to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves https://linear.app/aztec-labs/issue/F-512/disallow-registering-invalid-addresses-as-senders-in-pxe
PXE.registerSender()viaaddress.isValid()before storing them in the sender address bookTODO(F-512)comment inLogService.#getSecretsForSendersWhy validate at the API boundary instead of globally?
We considered enforcing validity at the
AztecAddressconstructor level, but this is impractical:isValid()is async (calls into Barretenberg WASM forbn254FrSqrt), so making construction enforce validity would require making all ~650+ construction sites asyncValidating at the PXE API boundary targets the real risk (invalid addresses from untrusted user input) without the migration and performance costs.
Test plan
registerSenderrejects an address with x=3 (not on the Grumpkin curve since y^2 = 10 has no square root in Fr)🤖 Generated with Claude Code