Skip to content

fix: disable debug field assertions in TranslatorRelationFailureTests #22680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AztecBot wants to merge 1 commit into from
Closed

fix: disable debug field assertions in TranslatorRelationFailureTests #22680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions barretenberg/cpp/src/barretenberg/translator_vm/relation_failure.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
* InRangeValueInMaskingFlowsToOrderedTail — trace FF(42) from wire masking through
* concatenation into ordered poly tail
*/
#include "barretenberg/common/assert.hpp"
#include "barretenberg/honk/library/grand_product_library.hpp"
#include "barretenberg/honk/relation_checker.hpp"
#include "barretenberg/translator_vm/translator_circuit_builder.hpp"
Expand Down Expand Up @@ -188,6 +189,15 @@ ValidTranslatorState build_valid_accumulator_transfer_state()
class TranslatorRelationFailureTests : public ::testing::Test {
protected:
static void SetUpTestSuite() { bb::srs::init_file_crs_factory(bb::srs::bb_crs_path()); }

// Corruption tests intentionally place witness values outside the ranges the relations assume
// (e.g. negative deltas, oversized sorted values). Evaluating the relation polynomials on such
// values can produce intermediate field elements that violate the debug-only
// `assert_coarse_form()` invariant (values must be in `[0, 2p)`), aborting the test before
// `RelationChecker::check` can report the expected failure. Downgrade debug field assertions
// to warnings — the test's `EXPECT_FALSE(failures.empty())` still validates the detection
// path. Same pattern as #21881 for `shplemini.test.cpp` HighDegreeAttack tests.
bb::AssertGuard assert_guard{ bb::AssertMode::WARN };
};

/**
Expand Down
Loading