Skip to content

fix(bb): allocate gemini_masking_poly at dyadic virtual size #22754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AztecBot wants to merge 2 commits into
base: merge-train/barretenberg
Choose a base branch
from
Open

fix(bb): allocate gemini_masking_poly at dyadic virtual size #22754

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1270aa
fix(bb): allocate gemini_masking_poly at dyadic virtual size
AztecBot Apr 24, 2026
fd9b8ce
Simplify comment
federicobarbacovi Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions barretenberg/cpp/src/barretenberg/ultra_honk/oink_prover.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,10 @@ template <typename Flavor> void OinkProver<Flavor>::commit_to_z_perm()
template <typename Flavor> void OinkProver<Flavor>::commit_to_masking_poly()
{
if constexpr (flavor_has_gemini_masking<Flavor>()) {
// Gemini masking poly only needs to cover the actual polynomial extent, not full dyadic size
// Gemini masking poly only needs random content up to the actual polynomial extent
const size_t polynomial_size = prover_instance->polynomials.max_end_index();
prover_instance->polynomials.gemini_masking_poly = Polynomial<FF>::random(polynomial_size);
prover_instance->polynomials.gemini_masking_poly =
Polynomial<FF>::random(polynomial_size, prover_instance->dyadic_size(), /*start_index=*/0);

// Commit to the masking polynomial and send to transcript
auto masking_commitment = commitment_key.commit(prover_instance->polynomials.gemini_masking_poly);
Expand Down
Loading