feat(avm)!: Remove is_infinite flag from AVM (PIL and EC points only)#22795
Merged
Conversation
MirandaWood
changed the base branch from
mw/avm-derive-is-inf
to
mw/avm-rem-inf-point-wrapper
MirandaWood
force-pushed
the
mw/avm-explore-remove-is-inf
branch
from
678ee83 to
1a0e853
Compare
MirandaWood
changed the title
is_infinite flag from AVM (PIL and EC points)
This was referenced May 5, 2026
MirandaWood
force-pushed
the
mw/avm-explore-remove-is-inf
branch
from
c591fb3 to
21e39fc
Compare
MirandaWood
changed the title
is_infinite flag from AVM (PIL and EC points)is_infinite flag from AVM (PIL and EC points only)
MirandaWood
force-pushed
the
mw/avm-explore-remove-is-inf
branch
from
b5782ae to
76989f9
Compare
IlyasRidhuan
approved these changes
May 12, 2026
MirandaWood
added a commit
that referenced
this pull request
May 12, 2026
…#22921) This branch solely contains the changes needed to remove the `is_infinite` flag from our `StandardAffinePoint` C++ wrapper. Now, we check whether `x` and `y` are zero to assign an `inf` underlying point. Will close [Foundation AVM Issue 17](https://linear.app/aztec-foundation/issue/AVM-17/remove-is-inf-flag-from-avms-standardaffinepoint) --- Stack: - #22745 - #22564 - `mw/avm-rem-inf-point-wrapper` <-- here - #22795 - #22945 - #23031
Base automatically changed from
mw/avm-rem-inf-point-wrapper
to
mw/avm-derive-is-inf
May 12, 2026 16:17
MirandaWood
added a commit
that referenced
this pull request
May 13, 2026
…#22945) This branch includes the changes to remove the `is_infinite` flags from the ECADD opcode fn signature. The actual EC logic changes come above this PR in the stack, and any changes outside the AVM will be below. For ease of review, I've separated into commits: - **feat: remove inf flags from ecadd opcode - ec flow only** Isolated to the EC flow only (does not change registers so non avm tests will fail) - f**eat: rem infs from fuzzer (only gadget fuzzer tested)** Isolated fixes to get the fuzzer(s) compiling Will partially close [Foundation AVM Issue 19](https://linear.app/aztec-foundation/issue/AVM-19/) (the following PR #23031 with ts/rs changes will fully close it). Note that the opcode mismatches that in ts so **CI will fail** until #23031 is merged into this branch! --- Stack: - #22745 - #22564 - #22921 - #22795 - `mw/avm-rem-inf-opcode-ecadd` <-- here - #23031
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch includes the changes to remove the
is_infiniteflag from our point representation and conceptually treating a point as infinite iff its coordinates are(0, 0).It only contains logic changes within the AVM for the above and does not touch the opcode - this is in a lower PR - so the CI will probably fail.
Will close Foundation AVM Issue 18
Stack:
is_infiniteflag from point coordinates #22564is_infiniteflag from point wrapper constructor #22921mw/avm-explore-remove-is-inf<-- hereis_infiniteflags from ECADD opcode (outside AVM only) #23031