Skip to content

fix(bb): allocate gemini masking poly with virtual size == dyadic #22937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iakovenkos merged 4 commits into from
May 6, 2026
Merged

fix(bb): allocate gemini masking poly with virtual size == dyadic #22937

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8d081c
fix(bb): pad gemini_masking_poly size to even to avoid sumcheck OOB
AztecBot May 5, 2026
376fdc2
Merge branch 'next' into claudebox/fix-nightly-bb-debug-build
iakovenkos May 6, 2026
326515a
fix the fix
iakovenkos May 6, 2026
d8dc15f
Merge branch 'merge-train/barretenberg' into claudebox/fix-nightly-bb…
iakovenkos May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions barretenberg/cpp/src/barretenberg/ultra_honk/oink_prover.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,10 @@ template <typename Flavor> void OinkProver<Flavor>::commit_to_z_perm()
template <typename Flavor> void OinkProver<Flavor>::commit_to_masking_poly()
{
if constexpr (flavor_has_gemini_masking<Flavor>()) {
// Gemini masking poly only needs to cover the actual polynomial extent, not full dyadic size
const size_t polynomial_size = prover_instance->polynomials.max_end_index();
prover_instance->polynomials.gemini_masking_poly = Polynomial<FF>::random(polynomial_size);
// virtual_size = dyadic_size matches every other witness poly, so sumcheck's pairwise read
// past end_index lands in the virtual-zero region.
prover_instance->polynomials.gemini_masking_poly = Polynomial<FF>::random(
prover_instance->polynomials.max_end_index(), prover_instance->dyadic_size(), /*start_index=*/0);

// Commit to the masking polynomial and send to transcript
auto masking_commitment = commitment_key.commit(prover_instance->polynomials.gemini_masking_poly);
Expand Down
Loading