feat(avm)!: WIP remove is_infinite flags from ECADD opcode (AVM only)#22945
Merged
Conversation
MirandaWood
force-pushed
the
mw/avm-rem-inf-opcode-ecadd
branch
2 times, most recently
from
9cf63b9 to
3d0e348
Compare
This was referenced May 7, 2026
MirandaWood
force-pushed
the
mw/avm-explore-remove-is-inf
branch
from
c591fb3 to
21e39fc
Compare
MirandaWood
force-pushed
the
mw/avm-rem-inf-opcode-ecadd
branch
from
3d0e348 to
856ad9d
Compare
MirandaWood
commented
May 8, 2026
MirandaWood
force-pushed
the
mw/avm-rem-inf-opcode-ecadd
branch
from
856ad9d to
22dd20e
Compare
MirandaWood
force-pushed
the
mw/avm-explore-remove-is-inf
branch
from
b5782ae to
76989f9
Compare
MirandaWood
force-pushed
the
mw/avm-rem-inf-opcode-ecadd
branch
from
22dd20e to
f0f77cb
Compare
IlyasRidhuan
approved these changes
May 12, 2026
MirandaWood
added a commit
that referenced
this pull request
May 12, 2026
…#22921) This branch solely contains the changes needed to remove the `is_infinite` flag from our `StandardAffinePoint` C++ wrapper. Now, we check whether `x` and `y` are zero to assign an `inf` underlying point. Will close [Foundation AVM Issue 17](https://linear.app/aztec-foundation/issue/AVM-17/remove-is-inf-flag-from-avms-standardaffinepoint) --- Stack: - #22745 - #22564 - `mw/avm-rem-inf-point-wrapper` <-- here - #22795 - #22945 - #23031
MirandaWood
added a commit
that referenced
this pull request
May 12, 2026
…y) (#22795) This branch includes the changes to remove the `is_infinite` flag from our point representation and conceptually treating a point as infinite iff its coordinates are `(0, 0)`. It only contains logic changes within the AVM for the above and does not touch the opcode - this is in a lower PR - so the **CI will probably fail**. Will close [Foundation AVM Issue 18](https://linear.app/aztec-foundation/issue/AVM-18/remove-is-inf-flag-from-resulting-ec-points-in-avm-circuits) --- Stack: - #22745 - #22564 - #22921 - `mw/avm-explore-remove-is-inf` <-- here - #22945 - #23031
Base automatically changed from
mw/avm-explore-remove-is-inf
to
mw/avm-derive-is-inf
May 12, 2026 16:22
MirandaWood
force-pushed
the
mw/avm-rem-inf-opcode-ecadd
branch
from
edf92df to
6b3e875
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch includes the changes to remove the
is_infiniteflags from the ECADD opcode fn signature. The actual EC logic changes come above this PR in the stack, and any changes outside the AVM will be below.For ease of review, I've separated into commits:
Will partially close Foundation AVM Issue 19 (the following PR #23031 with ts/rs changes will fully close it).
Note that the opcode mismatches that in ts so CI will fail until #23031 is merged into this branch!
Stack:
is_infiniteflag from point coordinates #22564is_infiniteflag from point wrapper constructor #22921is_infiniteflag from AVM (PIL and EC points only) #22795mw/avm-rem-inf-opcode-ecadd<-- hereis_infiniteflags from ECADD opcode (outside AVM only) #23031