feat: n1 apps#22974
Merged
Merged
Conversation
federicobarbacovi
force-pushed
the
lde/n1-apps
branch
from
8ad5bdd to
bce302f
Compare
federicobarbacovi
force-pushed
the
lde/n1-apps
branch
from
edb3c0f to
a0b7407
Compare
federicobarbacovi
force-pushed
the
lde/n1-apps
branch
from
a0b7407 to
f884fc4
Compare
| assert_eq(pi.expiration_timestamp, 78); | ||
| } | ||
|
|
||
| #[test] |
Contributor
There was a problem hiding this comment.
This test was simply missing in this test suite
federicobarbacovi
approved these changes
May 7, 2026
ledwards2225
commented
May 7, 2026
| stdlib_verification_queue.size() == 1 && (stdlib_verification_queue.front().type == QUEUE_TYPE::OINK); | ||
| bool is_init_kernel = stdlib_verification_queue.front().type == QUEUE_TYPE::OINK; | ||
|
|
||
| bool is_hiding_kernel = |
Contributor
Author
There was a problem hiding this comment.
the above makes me realize that this should probably just check queue type then assert queue size 1
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Thunkar
pushed a commit
that referenced
this pull request
May 8, 2026
## Summary Fix CI failure on `merge-train/fairies` (run [25572561023](https://github.com/AztecProtocol/aztec-packages/actions/runs/25572561023), log [1778264338812903](http://ci.aztec-labs.com/1778264338812903)). The merge of `next` into `merge-train/fairies` (78632af) brought in barretenberg changes — `feat!: optimized Poseidon2 (#22652)` and `feat: n1 apps (#22974)` via `feat: merge-train/barretenberg (#23025)` — which grew bb.js by enough to push the playground main entrypoint 0.02 KB over the 1750 KB hard limit: ``` ❌ assets/index-BEz4wQVA.js: 1750.02 KB exceeds limit of 1750 KB (Main entrypoint, hard limit) ``` Bumping the limit to 1800 KB (matching the prior +50 KB increment from the bump log) restores headroom. ## Test plan - [ ] CI green on this PR (chunk size check passes) ClaudeBox log: https://claudebox.work/s/22af49d0486fc035?run=1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial exploration of multi-app init/inner kernels. Currently just adds some basic lib utils and tests demonstrating feasibility of naively extending the current hard-coded single app pattern.