fix(archiver): restore pending block height metric under pipelining#22994
Merged
alexghr merged 2 commits intoMay 7, 2026
Merged
Conversation
…omoted Pipelining causes every checkpoint arriving from L1 to take the proposed-promotion fast path, leaving `checkpointsToAdd` empty and suppressing the `aztec.archiver.block_height` series without a status attribute (the "Pending chain" line on the dashboards). Record the metric across all valid checkpoints so the promoted path is also covered.
alexghr
approved these changes
May 7, 2026
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
aztec.archiver.block_heightseries with no status attribute (rendered as the "Pending chain" line on the network, prover, and fisherman Grafana dashboards) stopped being published a couple of weeks ago. With pipelining enabled every checkpoint arriving from L1 already has its blocks in the proposed store, so the L1 synchronizer always took the new promotion fast path introduced in #22716, leavingcheckpointsToAddempty and skipping the metric call.Approach
Record the checkpointed block-height metrics across all valid checkpoints in the batch instead of only the ones routed through
addCheckpoints, so the promoted checkpoint contributes too. The duration is averaged over the full batch sinceaddCheckpointsperforms the work for both paths in a single transaction.Changes
l1_synchronizer.ts): Move theprocessNewCheckpointedBlockscall to usevalidCheckpointsrather thancheckpointsToAdd, restoring the empty-statusblock_height,checkpoint_height,sync_block_count, andsync_per_checkpointseries under pipelining.