Skip to content

fix(pxe): only skip sync for stub overrides, not on-chain class overrides #23016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dbanks12 wants to merge 1 commit into from
Closed

fix(pxe): only skip sync for stub overrides, not on-chain class overrides #23016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions yarn-project/pxe/src/pxe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,9 +1013,20 @@ export class PXE {
const contractFunctionSimulator = this.#getSimulatorForTx(overrides);

if (hasOverriddenContracts) {
// Overridden contracts don't have a sync function, so calling sync on them would fail.
// We exclude them so the sync service skips them entirely.
this.contractSyncService.setExcludedFromSync(jobId, overriddenContracts);
// Skip sync for overrides whose class isn't published on chain (typically local-only stubs
// such as account stubs registered via pxe.registerContractClass). Their artifacts may be
// partial and break sync's nested utility execution. Overrides whose class is published
// on chain (e.g. fastForwardContractUpdate) have full artifacts and need sync to load
// pre-existing notes for the contract.
const stubAddresses = new Set<string>();
for (const [addrStr, override] of Object.entries(overrides!.contracts!)) {
if (!(await this.node.getContractClass(override.instance.currentContractClassId))) {
stubAddresses.add(addrStr);
}
}
if (stubAddresses.size > 0) {
this.contractSyncService.setExcludedFromSync(jobId, stubAddresses);
}
}

// Execution of private functions only; no proving, and no kernel logic.
Expand Down
Loading