Skip to content

fix(bb): clamp BatchMergeProver degree-check loop to fix nightly debug SIGABRT #23019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
federicobarbacovi merged 2 commits into from
May 7, 2026
Merged

fix(bb): clamp BatchMergeProver degree-check loop to fix nightly debug SIGABRT #23019

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c2fe02
fix(bb): clamp BatchMergeProver degree-check loop to avoid OOB in debug
AztecBot May 6, 2026
0a5b07c
Reset prover, fix test
federicobarbacovi May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions barretenberg/cpp/src/barretenberg/goblin/batch_merge.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,22 @@ class TweakableBatchMergeProver : public BatchMergeProver {
}

// Step 6: degree-check poly
bool is_too_many_subtables = flattened_cols.size() > num_degree_check_challenges;
if (is_too_many_subtables) {
// This is the case in which we test that if the prover sends more columns than the max number of tables
// then the verifier rejects
degree_check_challenges.push_back(degree_check_challenges.back() * degree_check_challenge);
}

Polynomial degree_check_poly =
compute_degree_check_polynomial(flattened_cols, degree_check_challenges, max_shift_size);

if (is_too_many_subtables) {
// Remove the extra challenge added above to keep the degree check poly consistent with the rest of the
// proof
degree_check_challenges.pop_back();
}

if (fault_mode == FaultMode::BAD_DEGREE_CHECK_POLY && !degree_check_poly.is_empty()) {
degree_check_poly.at(0) += FF(1);
}
Expand Down
Loading