chore: test#23037
Closed
alexghr wants to merge 1 commit into
Closed
Conversation
spalladino
reviewed
May 7, 2026
Comment on lines
+610
to
+611
| checkpointProposalOptions.broadcastInvalidCheckpointProposal ||= | ||
| blocksInCheckpoint.at(-1)?.indexWithinCheckpoint === this.config.invalidBlockProposalIndexWithinCheckpoint; |
Contributor
There was a problem hiding this comment.
Shouldn't this be the blockProposalOptions?
| ): Promise<BlockProposal> { | ||
| // For testing: change the new archive to trigger state_mismatch validation failure | ||
| if (options.broadcastInvalidBlockProposal) { | ||
| if (options.broadcastInvalidBlockProposal || options.broadcastInvalidThisBlockProposal) { |
Contributor
There was a problem hiding this comment.
What's the difference between the two?
Comment on lines
+28
to
+30
| const TEST_TIMEOUT = 1_000_000; | ||
|
|
||
| jest.setTimeout(TEST_TIMEOUT); |
Contributor
There was a problem hiding this comment.
I was going to comment on this, but I see we already have a test with this timeout, damn
Comment on lines
+223
to
+228
| await t.waitForP2PMeshConnectivity(nodes, NUM_VALIDATORS, 30, 0.1, [ | ||
| TopicType.tx, | ||
| TopicType.block_proposal, | ||
| TopicType.checkpoint_proposal, | ||
| TopicType.checkpoint_attestation, | ||
| ]); |
Contributor
There was a problem hiding this comment.
I'd run this test with mocked gossipsub network
| blocks: await Promise.all( | ||
| badCheckpointBlockHashes.map(async block => ({ | ||
| ...block, | ||
| worldStateHash: await getArchiveLeafHash(node, block.number), |
Contributor
There was a problem hiding this comment.
Why not just issue a getBlockData on the node and compare the block hashes?
Contributor
Author
|
Closing in favour of #23184 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test for A-521