fix(e2e): bump fee_settings test fees past the captured baseline#23087
Draft
AztecBot wants to merge 1 commit into
Draft
fix(e2e): bump fee_settings test fees past the captured baseline#23087AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
e2e_fees fee_settings > handles min fee spikes with default paddingfailure in themerge-train/fairiesCI run after PR #23048 was merged (log).The test captures
stableMinFeesright afterTestContractis deployed (a local peak infeePerL2Gas), then proves two txs (slow), then callsbumpL2Fees(). By the timebumpL2Fees()runs, the chain's min fees have decayed belowstableMinFees. A single 20% proving-cost bump only adds ~5% to totalfeePerL2Gas, which is not enough to climb back above the captured peak — soexpect(stableMinFees < bumpedMinFees)fails.bumpL2Feesnow accepts an optionalminTargetand bumps proving cost in a loop (each iteration waits for the bump to take effect via the existingretryUntil) until the chain's current min fees exceed the target. Both tests pass their baseline so the comparison is robust to decay. The padded-fee bound istarget.mul(1 + DEFAULT_MIN_FEE_PADDING)(=target * 6), so there is plenty of headroom on the upper side.PR #23048 itself is a pxe tagging refactor and doesn't touch fees — this is a pre-existing flake in the test that surfaced under this run's timing. The same approach was previously prepared in #22583, which was auto-closed only because it went stale.
Notes
./bootstrap.sh ci-fastcould not be exercised in this container (UID mismatch on~/.cacheblocks the noir bootstrap, no Docker for spartan). The merge-train CI will exercise the change directly.ClaudeBox log: https://claudebox.work/s/c40fed098084dd7b?run=2