Skip to content

fix: add Tag.random() helper required by backported #23088 tests#23094

Merged
vezenovm merged 1 commit into
backport-to-v4-next-stagingfrom
claudebox/fix-pr-23080-ci
May 8, 2026
Merged

fix: add Tag.random() helper required by backported #23088 tests#23094
vezenovm merged 1 commit into
backport-to-v4-next-stagingfrom
claudebox/fix-pr-23080-ci

Conversation

@AztecBot
Copy link
Copy Markdown
Collaborator

@AztecBot AztecBot commented May 8, 2026

Summary

CI3 on PR #23080 failed because the backported tests in log_service.test.ts (from #23088) call Tag.random(), but the Tag class on v4-next does not yet have that static factory — it was added on next by #22516, which has not been backported.

This adds Tag.random() (and switches Fr from a type-only import) on the v4-next branch. Mirrors the upstream definition exactly.

Test plan

ClaudeBox log: https://claudebox.work/s/3be07c7bc11fd1d8?run=1

@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels May 8, 2026
@vezenovm
Copy link
Copy Markdown
Contributor

vezenovm commented May 8, 2026

@nchamo fyi I ran into this on #23060

@vezenovm vezenovm marked this pull request as ready for review May 8, 2026 13:32
@vezenovm vezenovm enabled auto-merge May 8, 2026 13:32
@AztecBot
Copy link
Copy Markdown
Collaborator Author

AztecBot commented May 8, 2026

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/b2e35ba283b12f0c�b2e35ba283b12f0c8;;�): yarn-project/kv-store/scripts/run_test.sh src/indexeddb/multi_map.test.ts (5s) (code: 0)

@vezenovm vezenovm merged commit 4963646 into backport-to-v4-next-staging May 8, 2026
32 of 42 checks passed
@vezenovm vezenovm deleted the claudebox/fix-pr-23080-ci branch May 8, 2026 13:50
AztecBot added a commit that referenced this pull request May 9, 2026
BEGIN_COMMIT_OVERRIDE
fix(aztec-up): Aztec installer does not shadow user installed binaries
on PATH (#22902)
fix: include sqlite binary in its npm package (#23039)
chore: backport #23041 (add sendMessagesAs to wallet api schemas) to
v4-next (#23081)
chore: backport DeployMethod refactor (#22985) to v4-next (#23029)
refactor(pxe): deduplicate tx hash lookups in MessageContextService
(#23075)
refactor(pxe): batch tagged private log queries across all secrets
(#23048)
refactor(pxe): batch log RPC calls in LogService.fetchLogsByTag (#23088)
feat(aztec-nr): Initial handshake registry contract with non interactive
handshake function (#22854)
fix: add Tag.random() helper required by backported #23088 tests
(#23094)
chore: backport: fix(aztec-up): installer does not shadow user binaries
on PATH (#22902) (#23060)
chore: backport handshake registry contract (#22854) to v4-next (#23063)
feat: deploy method refactor 2 (#23033)
refactor(pxe): skip redundant getBlock RPC when querying at anchor block
(#23100)
port(v4-next): feat(docs): autogenerate node JSON-RPC API reference
(#22543) (#23046)
chore: backport feat: deploy method refactor 2 (#23033) to v4-next
(#23103)
port(v4-next): feat(ci): Snapshots for aztec-nr contract compilation
failures and nargo expand (#23061) (#23104)
feat(txe): allow authorizing cross-contract utility calls in nr tests
(#23064)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants