fix(bb): cache Emscripten .js / .worker.mjs siblings of .wasm targets#23122
Closed
AztecBot wants to merge 1 commit into
Closed
fix(bb): cache Emscripten .js / .worker.mjs siblings of .wasm targets#23122AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
…m targets preset_cache_paths only matched targets by name + native sibling extensions (.exe, .node, lib*.a). Emscripten emits a .js loader and .worker.mjs pthread worker alongside every .wasm exec target as a unit, so cache_upload missed them and a wasm-threads cache hit restored barretenberg.wasm without the matching barretenberg.js. bb-ts/scripts/copy_wasm.sh then unconditionally copies cpp/build-wasm-threads/ bin/barretenberg.js into dest/<flavor>/barretenberg_wasm/, which fast-mode CI hits before any cache miss can rebuild the cpp side, producing: cp: cannot stat '../cpp/build-wasm-threads/bin/barretenberg.js': No such file or directory Extend preset_cache_paths so any target ending in .wasm also picks up the $stem.js and $stem.worker.mjs siblings from the same bin/ directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded — same commit landed directly on #22815's branch (
claudebox/a62d1521c38e34c3-3) once the cb/-prefix push guard was relaxed. Closing.