refactor(pxe): skip storage reads for never-updated contracts#23131
Open
nchamo wants to merge 2 commits intomerge-train/fairiesfrom
Open
refactor(pxe): skip storage reads for never-updated contracts#23131nchamo wants to merge 2 commits intomerge-train/fairiesfrom
nchamo wants to merge 2 commits intomerge-train/fairiesfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getUpdatedClassIdHintspreviously always calledDelayedPublicMutableValues.readFromTree, which triggers multiplegetPublicStorageAtRPC calls. The vast majority of contracts are never updated, so these reads return empty values.getPublicDataWitnessresult we already fetch: in an indexed merkle tree, a non-matchingleaf.slotmeans the slot has never been written, so we can skip the reads and returnDelayedPublicMutableValues.empty(...)directly.e2e_contract_updates.test.tsexercises both cases end-to-end (before and after a contract class update).