Skip to content

fix(ci3): accept slashes in /list/<path:key> for merge-train history #23160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalladino merged 2 commits into from
May 12, 2026
Merged

fix(ci3): accept slashes in /list/<path:key> for merge-train history #23160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0c8445
fix(ci3): sanitize slash in TARGET_BRANCH for test history URL
AztecBot May 11, 2026
09100c6
fix(ci3): accept slashes in /list/<path:key> for merge-train hi…
AztecBot May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ci3/dashboard/rk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,11 @@ def show_section(section):
follow='top'
)

@app.route('/list/<key>')
# <path:key> (not <key>) so branch-qualified history keys like
# `history_<hash>_merge-train/spartan` route correctly. WSGI decodes %2F to /
# in PATH_INFO before Flask routes, so percent-encoding can't rescue a plain
# <key> converter — only <path:key> matches segments containing /.
@app.route('/list/<path:key>')
@optional_auth
def get_list(key):
value = get_list_as_string(key)
Expand Down
Loading