test: slash on bad attestation#23184
Merged
Merged
Conversation
alexghr
force-pushed
the
ag/slash-bad-attestation
branch
from
7849cda to
b6ab9ce
Compare
alexghr
force-pushed
the
ag/bad-attestation-tests
branch
from
6b87d1f to
15ab87c
Compare
alexghr
force-pushed
the
ag/bad-attestation-tests
branch
from
56235c7 to
97e7ae6
Compare
Closed
alexghr
force-pushed
the
ag/bad-attestation-tests
branch
2 times, most recently
from
114bc7a to
872b751
Compare
alexghr
changed the title
alexghr
force-pushed
the
ag/bad-attestation-tests
branch
2 times, most recently
from
114bc7a to
c5f8135
Compare
alexghr
changed the title
alexghr
force-pushed
the
ag/bad-attestation-tests
branch
from
c5f8135 to
a8e3fb0
Compare
spalladino
approved these changes
May 14, 2026
Contributor
spalladino
left a comment
spalladino
left a comment
There was a problem hiding this comment.
LGTM. I wonder if the two tests could be merged in the interest of lowering running time, like asserting the offense, and then checking it's cleared once you push the equivocation. That'd also allow to inline the create scenario helper maybe.
Comment on lines
+269
to
+274
| await t.waitForP2PMeshConnectivity(nodes, NUM_VALIDATORS, 30, 0.1, [ | ||
| TopicType.tx, | ||
| TopicType.block_proposal, | ||
| TopicType.checkpoint_proposal, | ||
| TopicType.checkpoint_attestation, | ||
| ]); |
Contributor
There was a problem hiding this comment.
I think you shouldn't need this under mockGossipSubNetwork
Comment on lines
+434
to
+439
| for (const { description, validator, offenseType } of expectedSlashOffenses) { | ||
| const offense = findExpectedOffense(validator, offenseType); | ||
| expect(offense).toBeDefined(); | ||
| expect(offense!.amount).toBeGreaterThan(0n); | ||
| t.logger.warn(`Observed expected slash offense: ${description}`, { offense }); | ||
| } |
Contributor
There was a problem hiding this comment.
Isn't this the same as the retryUntil above?
alexghr
force-pushed
the
ag/bad-attestation-tests
branch
from
a8e3fb0 to
9f010ee
Compare
alexghr
force-pushed
the
ag/bad-attestation-tests
branch
from
9f010ee to
081fc7c
Compare
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #23180