fix(ci): swap slack_notify args in CLI acceptance test#23241
Merged
Conversation
The slack_notify script expects (text, channel) but the workflow was passing (channel, text), silently posting to a nonexistent channel.
Thunkar
approved these changes
May 13, 2026
AztecBot
pushed a commit
that referenced
this pull request
May 13, 2026
Collaborator
|
✅ Successfully backported to backport-to-v4-next-staging #23236. |
AztecBot
added a commit
that referenced
this pull request
May 14, 2026
BEGIN_COMMIT_OVERRIDE feat: package sqlite kv-store backend for stricter browser envs (#23089) fix(pxe): sync target contract before cross-contract utility call (#23225) fix(ci): swap slack_notify args in CLI acceptance test (#23241) feat: optimize get next app tag as sender (#23239) fix(noir): noirfmt nested_utility_contract main.nr (#23246) chore(aztec-nr): mark emit_event_in_public as #[inline_never] to shrink public dispatch (#23161) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slack_notifyscript expects(text, channel)but the CLI acceptance test workflow was passing(channel, text), so the success notification was silently posting to a nonexistent Slack channel.slack_notify_with_claudebox_kickoffwhich has the opposite convention(channel, text)and was correct.