ci: proposal — notify #team-alpha on merge-train/spartan MQ failures#23242
Closed
AztecBot wants to merge 1 commit into
Closed
ci: proposal — notify #team-alpha on merge-train/spartan MQ failures#23242AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proposal (not directly applied) to add a Slack notification to
#team-alpha(C0AU8BULZHC) whenever the CI3 job fails formerge-train/spartanin the merge queue.The ClaudeBox session was not started with
ci-allow, so.github/edits were blocked. The patch is dropped in.github-new/workflows/ci3-spartan-mq-notify.mdfor someone to apply manually (or rerun the request prefixed withci-allow).Why
Today the only failure notification for
merge-train/spartanin the MQ ismerge-queue-dequeue-notify.yml, which fires on thepull_request: dequeuedevent. If GitHub's merge queue retries and the retry succeeds, that event never fires and the team gets no signal about the underlying flake/failure.Patch (also embedded in the proposal file)
Add this step to the
cijob in.github/workflows/ci3.yml, immediately after the existingNotify Slack on backport CI failurestep:Detection
env.CI_MODE == 'merge-queue-heavy'is set by.github/ci3_labels_to_env.shonly when amerge_groupevent corresponds to a PR whose head branch ismerge-train/spartan. Other MQ runs useCI_MODE=merge-queueand won't trigger this notification.Test plan
merge-train/spartanPR to fail in the MQ and confirm a notification arrives in #team-alpha.ClaudeBox log: https://claudebox.work/s/59af479c755d74ef?run=1