refactor(stdlib): remove deprecated RevertCode/TxExecutionResult aliases#23249
Merged
spalladino merged 1 commit intoMay 13, 2026
Merged
Conversation
…aliases Drops the APP_LOGIC_REVERTED, TEARDOWN_REVERTED, and BOTH_REVERTED members from both RevertCode and TxExecutionResult in favor of the unified REVERTED. Updates all call sites accordingly.
spalladino
requested review from
IlyasRidhuan,
MirandaWood and
jeanmon
as code owners
PhilWindle
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
RevertCodeandTxExecutionResulttypes each carried three deprecated aliases (APP_LOGIC_REVERTED,TEARDOWN_REVERTED,BOTH_REVERTED) that all collapse to the sameREVERTEDvalue. Keeping them around adds noise, requiresno-duplicate-enum-valueseslint suppressions, and lets new code keep reaching for the old names.Approach
Removed the deprecated members from both enums and rewrote every call site to use
REVERTEDdirectly. Tests, fixtures, and a stale doc reference were updated to match.Changes
APP_LOGIC_REVERTED/TEARDOWN_REVERTED/BOTH_REVERTEDfromRevertCodeandTxExecutionResult.REVERTED.APP_LOGIC_REVERTEDreference in the public-tx-simulation doc.