fix(aztec-up): allow verdaccio publish when npmjs uplink is offline#23255
Draft
AztecBot wants to merge 1 commit into
Draft
fix(aztec-up): allow verdaccio publish when npmjs uplink is offline#23255AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
aztec-upstep inbootstrap.sh ci-full-no-test-cachestands up a local Verdaccio and publishes every@aztec/*and@noir-lang/*workspace package to it. When npmjs.org is briefly unreachable, Verdaccio caches the uplink as down for ~5 minutes (defaultfail_timeout) and refuses every publish in that window with:This bricked the merge-train CI run for
merge-train/spartan(https://github.com/AztecProtocol/aztec-packages/actions/runs/25813115286, log1778689953741897) even though the change itself (#23245 TxCollection refactor) is unrelated. The existing 3× retry inaztec-up/bootstrap.shdoesn't help because the cached uplink-down state outlives all retries — see the existing TODO on that line.Fix
Add
publish.allow_offline: trueto the Verdaccio config. In Verdaccio'scheckPackageRemote(seestorage-utils.js), a non-404 uplink error normally producesUPLINK_OFFLINE_PUBLISH(the 503 above); withallow_offlineset, that path resolves instead of rejecting, so transient npmjs hiccups no longer block local publish. Install/proxy behaviour for non-published packages is unchanged.Test plan
bootstrap.sh ci-full-no-test-cachepasses through theaztec-upstep_isAllowPublishOfflinereadspublish.allow_offline(pernode_modules/verdaccio/build/lib/storage.js). Full reproduction needs Docker which isn't available in this environment.Full analysis: https://gist.github.com/AztecBot/9b0ccd4e3bbc1714bf490594037023ba
ClaudeBox log: https://claudebox.work/s/7ac785ba8051506f?run=1